Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmake] update minimum version of libdrm #15818

Merged
merged 1 commit into from Mar 27, 2019
Merged

[cmake] update minimum version of libdrm #15818

merged 1 commit into from Mar 27, 2019

Conversation

olafhering
Copy link
Contributor

With the usage of DRM_FORMAT_GR1616 via commit
b73d078 ("[vaapi] Make CVaapiTexture
into an interface, factor out vaapi1") a newer libdrm is required.

Adjust the pkgconfig check accordingly.

Signed-off-by: Olaf Hering olaf@aepfle.de

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@olafhering
[cmake] update minimum version of libdrm
1754921 
With the usage of DRM_FORMAT_GR1616 via commit
b73d078 ("[vaapi] Make CVaapiTexture
into an interface, factor out vaapi1") a newer libdrm is required.

Adjust the pkgconfig check accordingly.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
@olafhering
Copy link
Contributor Author

As an alternative, restore the usage of fourcc_code('G', 'R', '3', '2').

@Rechi Rechi added Type: Improvement non-breaking change which improves existing functionality Platform: Linux CMake v18 Leia labels Mar 27, 2019
@Rechi Rechi added this to the Leia 18.2-rc1 milestone Mar 27, 2019
@wsnipex wsnipex requested a review from yol March 27, 2019 08:38
@yol
Copy link
Member

yol commented Mar 27, 2019

Thanks!

@yol yol merged commit ff61ada into xbmc:master Mar 27, 2019
@olafhering olafhering deleted the DRM_FORMAT_GR1616 branch March 27, 2019 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yol yol yol approved these changes

Assignees
No one assigned
Labels
CMake Platform: Linux Type: Improvement non-breaking change which improves existing functionality v18 Leia
Projects
None yet
Milestone
Leia 18.2-rc1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@olafhering @yol @Rechi