[tests] use correct storage size #15855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce noise in build output. d:\win-64\xbmc\utils\test\teststringutils.cpp(335): warning C4267: '=': conversion from 'size_t' to 'int' d:\win-64\xbmc\utils\test\teststringutils.cpp(397): warning C4267: '=': conversion from 'size_t' to 'int' d:\win-64\xbmc\utils\test\teststringutils.cpp(399): warning C4267: '=': conversion from 'size_t' to 'int' d:\win-64\xbmc\utils\test\teststringutils.cpp(401): warning C4267: '=': conversion from 'size_t' to 'int' d:\win-64\xbmc\utils\test\teststringutils.cpp(404): warning C4267: '=': conversion from 'size_t' to 'int' d:\win-64\xbmc\utils\test\teststringutils.cpp(406): warning C4267: '=': conversion from 'size_t' to 'int' d:\win-64\xbmc\utils\test\teststringutils.cpp(408): warning C4267: '=': conversion from 'size_t' to 'int' d:\win-64\xbmc\utils\test\teststringutils.cpp(410): warning C4267: '=': conversion from 'size_t' to 'int' d:\win-64\xbmc\utils\test\teststringutils.cpp(419): warning C4267: '=': conversion from 'size_t' to 'int' d:\win-64\xbmc\utils\test\teststringutils.cpp(421): warning C4267: '=': conversion from 'size_t' to 'int' d:\win-64\xbmc\utils\test\teststringutils.cpp(423): warning C4267: '=': conversion from 'size_t' to 'int' d:\win-64\xbmc\utils\test\teststringutils.cpp(426): warning C4267: '=': conversion from 'size_t' to 'int' Signed-off-by: Olaf Hering <olaf@aepfle.de>
yol
reviewed
Apr 2, 2019
yol
reviewed
Apr 2, 2019
Reduce noise in build output. d:\win-64\xbmc\utils\test\testregexp.cpp(155): warning C4244: '=': conversion from 'ssize_t' to 'unsigned int', d:\win-64\xbmc\utils\test\testlog.cpp(105): warning C4244: '=': conversion from 'ssize_t' to 'unsigned int' d:\win-64\xbmc\test\testutils.cpp(142): warning C4244: '=': conversion from 'ssize_t' to 'unsigned int', d:\win-64\xbmc\filesystem\test\testzipfile.cpp(185): warning C4244: '=': conversion from 'ssize_t' to 'unsigned int', d:\win-64\xbmc\filesystem\test\testfilefactory.cpp(75): warning C4244: '=': conversion from 'ssize_t' to 'unsigned int' d:\win-64\xbmc\filesystem\test\testfilefactory.cpp(120): warning C4244: '=': conversion from 'ssize_t' to 'unsigned int', d:\win-64\xbmc\filesystem\test\testfilefactory.cpp(136): warning C4244: '=': conversion from 'ssize_t' to 'unsigned int' d:\win-64\xbmc\filesystem\test\testfile.cpp(22): warning C4267: 'initializing': conversion from 'size_t' to 'int' d:\win-64\xbmc\filesystem\test\testfile.cpp(42): warning C4267: '=': conversion from 'size_t' to 'int' d:\win-64\xbmc\filesystem\test\testfile.cpp(46): warning C4267: '+=': conversion from 'size_t' to 'int' d:\win-64\xbmc\filesystem\test\testfile.cpp(54): warning C4267: '+=': conversion from 'size_t' to 'int' d:\win-64\xbmc\filesystem\test\testfile.cpp(62): warning C4267: '+=': conversion from 'size_t' to 'int' d:\win-64\xbmc\filesystem\test\testfile.cpp(65): warning C4267: '=': conversion from 'size_t' to 'int' d:\win-64\xbmc\filesystem\test\testfile.cpp(70): warning C4267: '+=': conversion from 'size_t' to 'int' d:\win-64\xbmc\filesystem\test\testfile.cpp(80): warning C4267: '+=': conversion from 'size_t' to 'int' Add cast to sizeof() result to fix this warning: warning: comparison between signed and unsigned integer expressions Signed-off-by: Olaf Hering <olaf@aepfle.de>
|
Updated with static_cast. Android builds are broken, looks unrelated to my change. |
|
More |
|
jenkins build and merge |
yol
approved these changes
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of change
Checklist: