Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CEGLImage: dump attributes if the import fails #15885

Merged
merged 2 commits into from Apr 18, 2019
Merged

CEGLImage: dump attributes if the import fails #15885

merged 2 commits into from Apr 18, 2019

Conversation

lrusak
Copy link
Contributor

@lrusak lrusak commented Apr 9, 2019

This has been really helpful for me to debug EGL image import failures.

example:

2019-04-08 19:34:03.775 T:140703923112320   DEBUG: CEGLImage::CreateImage - attributes:
                                            EGL_DMA_BUF_PLANE0_PITCH_EXT: 512
                                            EGL_DMA_BUF_PLANE0_OFFSET_EXT: 0
                                            EGL_DMA_BUF_PLANE0_FD_EXT: 57
                                            EGL_LINUX_DRM_FOURCC_EXT: 909199186
                                            EGL_HEIGHT: 240
                                            EGL_WIDTH: 256

@lrusak lrusak added this to the Leia 18.2-rc1 milestone Apr 9, 2019
@lrusak lrusak requested a review from yol April 9, 2019 02:35
yol
yol reviewed Apr 9, 2019
View reviewed changes
xbmc/utils/EGLUtils.h Outdated Show resolved Hide resolved
xbmc/utils/EGLImage.cpp Outdated Show resolved Hide resolved
xbmc/utils/EGLImage.cpp Show resolved Hide resolved
xbmc/utils/EGLImage.cpp Show resolved Hide resolved
xbmc/utils/EGLImage.cpp Outdated Show resolved Hide resolved
yol
yol reviewed Apr 13, 2019
View reviewed changes
xbmc/utils/EGLUtils.h Outdated Show resolved Hide resolved
@Rechi Rechi removed the v18 Leia label Apr 16, 2019
@Rechi Rechi removed this from the Leia 18.2-rc1 milestone Apr 16, 2019
@lrusak
Copy link
Contributor Author

lrusak commented Apr 17, 2019

@pkerling updated and rebased

yol
yol approved these changes Apr 17, 2019
View reviewed changes
Copy link
Member

@yol yol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Hope the Size() confusion is cleared up now

@lrusak lrusak merged commit 8b3ca87 into xbmc:master Apr 18, 2019
@Rechi Rechi added this to the M** 19.0-alpha 1 milestone Apr 18, 2019
@lrusak lrusak deleted the eglimage-dump-attrs branch February 11, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yol yol yol approved these changes

Assignees
No one assigned
Labels
Component: GLES rendering Component: Logging Platform: Linux Type: Improvement non-breaking change which improves existing functionality v19 Matrix
Projects
None yet
Milestone
Matrix 19.0-alpha 1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lrusak @yol @Rechi