Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmake] enable using ccache with xcode #15886

Merged
merged 1 commit into from Apr 16, 2019
Merged

[cmake] enable using ccache with xcode #15886

merged 1 commit into from Apr 16, 2019

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Apr 9, 2019

Motivation and Context

speed up build process for xcode users

How Has This Been Tested?

  • zeroed ccache statistics counters
  • generated xcode project
  • build kodi
  • checked ccache statistics summary
  • touched all cpp and mm files in lib/libUPnP and xbmc
  • zeroed ccache statistics counters
  • build kodi
  • checked ccache statistics summary

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi Rechi added Type: Improvement non-breaking change which improves existing functionality CMake labels Apr 9, 2019
@Rechi Rechi requested review from Memphiz and wsnipex April 9, 2019 07:19
Memphiz
Memphiz approved these changes Apr 9, 2019
View reviewed changes
Copy link
Member

@Memphiz Memphiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok after leia branch

@Rechi Rechi force-pushed the xcode/ccache branch 4 times, most recently from c3313bc to bcc2188 Compare April 13, 2019 17:58
@Rechi Rechi added this to the M** 19.0-alpha 1 milestone Apr 16, 2019
@Rechi Rechi merged commit d4ae297 into xbmc:master Apr 16, 2019
@Rechi Rechi deleted the xcode/ccache branch April 16, 2019 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Memphiz Memphiz Memphiz approved these changes

@wsnipex wsnipex Awaiting requested review from wsnipex

Assignees
No one assigned
Labels
CMake Type: Improvement non-breaking change which improves existing functionality v19 Matrix
Projects
None yet
Milestone
Matrix 19.0-alpha 1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rechi @Memphiz