Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[interfaces] use fixed date string in PythonSwig.cpp #15898

Merged
merged 1 commit into from Apr 19, 2019
Merged

[interfaces] use fixed date string in PythonSwig.cpp #15898

merged 1 commit into from Apr 19, 2019

Conversation

olafhering
Copy link
Contributor

@olafhering olafhering commented Apr 11, 2019 •
edited

The buildtime of an application has no meaning.
What might be interesting, and relevant, would be the source state, like a
git hash or versioned release.
Inserting such thing breaks what Debian sells as reproducible builds.

Signed-off-by: Olaf Hering olaf@aepfle.de

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@olafhering
Copy link
Contributor Author

pull request updated

Rechi
Rechi reviewed Apr 13, 2019
View reviewed changes
Copy link
Member

@Rechi Rechi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message and PR title are wrong, because the date attribute isn't removed.

xbmc/interfaces/python/PythonSwig.cpp.template Outdated Show resolved Hide resolved
@olafhering olafhering changed the title [interfaces] remove date string from PythonSwig.cpp [interfaces] use fixed date string in PythonSwig.cpp Apr 13, 2019
@olafhering
[interfaces] use fixed date string in PythonSwig.cpp
0ed6358 
The buildtime of an application has no meaning.
What might be interesting, and relevant, would be the source state, like a
git hash or versioned release.
Inserting such thing breaks what Debian sells as reproducible builds.

Adjust the code to use the fixed string from CCompileInfo::GetBuildDate.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
@olafhering
Copy link
Contributor Author

Thanks for the review.

@Rechi Rechi added Component: Python Type: Improvement non-breaking change which improves existing functionality v19 Matrix labels Apr 19, 2019
@Rechi Rechi added this to the M** 19.0-alpha 1 milestone Apr 19, 2019
@Rechi Rechi merged commit 8df47b3 into xbmc:master Apr 19, 2019
@olafhering olafhering deleted the PyModule_AddStringConstant branch April 20, 2019 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rechi Rechi Rechi left review comments

@wsnipex wsnipex wsnipex approved these changes

Assignees
No one assigned
Labels
Component: Python Type: Improvement non-breaking change which improves existing functionality v19 Matrix
Projects
None yet
Milestone
Matrix 19.0-alpha 1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@olafhering @wsnipex @Rechi