-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PVR][addons][json-rpc][estuary][estouchy] PVR Addon API 6.0.0 #15953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@arthur-liberman this PR supersedes #14736. |
Cool! Should I close my PR then? |
Yes, please do. |
13 tasks
@Jalle19 please review. |
@ronie do the skin changes look okay? |
ronie
approved these changes
Apr 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
This was referenced Apr 23, 2019
This was referenced Apr 23, 2019
Jalle19
reviewed
Apr 24, 2019
@Jalle19 good to go? |
…'GetEPGForChannel'.
…PE_STRING_LENGTH and PVR_ADDON_ATTRIBUTE_DESC_LENGTH. We encountered situations where they were to small for localized strings for multibyte languages.
…, Add GUI info bools ListItem.HasArchive and ListItem.IsPlayable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API change: JSON-RPC
API change: PVR
Component: PVR
Type: Cleanup
non-breaking change which removes non-working or unmaintained functionality
Type: Feature
non-breaking change which adds functionality
Type: Improvement
non-breaking change which improves existing functionality
v19 Matrix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misc PVR Addon API changes and respective Kodi/skin implementations we collected during the last month, while master was blocked for incomatible API changes.