Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR][addons][json-rpc][estuary][estouchy] PVR Addon API 6.0.0 #15953

Merged
merged 10 commits into from
Apr 24, 2019

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Apr 21, 2019

Misc PVR Addon API changes and respective Kodi/skin implementations we collected during the last month, while master was blocked for incomatible API changes.

@ksooo ksooo added Type: Feature non-breaking change which adds functionality Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Type: Improvement non-breaking change which improves existing functionality Component: PVR API change: JSON-RPC API change: PVR v19 Matrix labels Apr 21, 2019
@ksooo ksooo added this to the M** 19.0-alpha 1 milestone Apr 21, 2019
@ksooo
Copy link
Member Author

ksooo commented Apr 21, 2019

@arthur-liberman this PR supersedes #14736.

@arthur-liberman
Copy link
Contributor

Cool! Should I close my PR then?

@ksooo
Copy link
Member Author

ksooo commented Apr 22, 2019

Yes, please do.

@ksooo
Copy link
Member Author

ksooo commented Apr 23, 2019

@Jalle19 please review.

@ksooo
Copy link
Member Author

ksooo commented Apr 23, 2019

@ronie do the skin changes look okay?

@ksooo ksooo requested a review from ronie April 23, 2019 19:18
Copy link
Member

@ronie ronie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

xbmc/addons/PVRClient.cpp Show resolved Hide resolved
xbmc/pvr/epg/EpgDatabase.cpp Outdated Show resolved Hide resolved
@ksooo
Copy link
Member Author

ksooo commented Apr 24, 2019

@Jalle19 good to go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change: JSON-RPC API change: PVR Component: PVR Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Type: Feature non-breaking change which adds functionality Type: Improvement non-breaking change which improves existing functionality v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants