-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fanart to hide spoilers if available #15991
Conversation
That looks cool so a 👍 generally from my side. Currently on holidays till Sunday. Will take a deeper look when I'm back. Thanks for that |
Would not mind using this for shows/episodes that do not have have thumbnails as well. I watch a lot of korean/asian dramas and many never get any thumbnails or if they do maybe weeks or months later. |
Tested and it works great. Thanks much for that 👍 For me it's good to go |
@@ -360,7 +360,15 @@ bool CVideoThumbLoader::LoadItemCached(CFileItem* pItem) | |||
!setting->FindIntInList(CSettings::VIDEOLIBRARY_THUMB_SHOW_UNWATCHED_EPISODE) | |||
) | |||
{ | |||
pItem->SetArt("thumb", "OverlaySpoiler.png"); | |||
// use fanart if available | |||
if(pItem->HasArt("fanart")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blank between "if" and "(" missing. :-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/xbmc/xbmc/blob/master/docs/CODE_GUIDELINES.md#34-whitespace
=> "Control statement keywords have to be separated from opening parentheses by one space."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry that I missed this, I'm used to the autoformatter but my settings are not compatible with other parts of the code guidelines. I made a pull request (#16019) to fix this and an other instance of the same problem.
Description
Currently if thumbnails are hidden to prevent spoilers a generic OverlaySoiler image are shown instead of the thumbnail. In my opinion it would look way better if the fanart of the show is displayed instead of this, this pull requests implements this change. Of course maybe this only my opinion, so I'm open for suggestions, maybe it should be put behind a setting.
Motivation and Context
I'm a long time user of trakt.tv where the hiding of spoilers are achieved with the fanart, that's the source of this idea. Also it helps the visual identification of the show especially in the recently added section.
How Has This Been Tested?
Manually by checking on the GUI.
Screenshots (if appropriate):
With the old behavior:
![image](https://user-images.githubusercontent.com/6945600/56762965-6e557280-67a1-11e9-8f7a-604fa6dc8e91.png)
With the new behavior:
![image](https://user-images.githubusercontent.com/6945600/56763015-904ef500-67a1-11e9-8a1f-4c4a34c49223.png)
Types of change
I marked it as improvement, but it can be also a "new feature"
Checklist: