-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed: Resume bookmark would clear on player start failure #16004
Conversation
jenkins build this please |
Please, is it possible to apply this fix also to Kodi 19? |
Yes, it will be backported to v19 as soon as it's merged in master. |
@arnova wrong way around. The PR needs to be raised against master (v19) please, tagged with backport needed. Then a second PR raised for v18 tagged with backport, wait until v19 PR is merged before merging v18 one and finally once that is done edit tag on v19 PR to say backport-done |
@DaveTBlake / @iz8mbw : This one IS against master (v19) ;-) Due to the confusion I said v19 where I meant v18 but thanks for the heads up :) |
Happy to test it in the next nightly. |
04f01ff
to
1b4a186
Compare
When this PR will be merged? |
jenkins build this please |
Jenk is sleeping :-) |
Could you please stop spamming. Everytime you write here, many people get notified. So, please only speak up if you actually have something to say. |
With v18 when a (video) item already has a resume bookmark set and the player fails to start (eg. NAS down / network problem) the item's resume bookmark will be cleared. Obviously this is not something most people want. It's also a regression from v17.