Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: Resume bookmark would clear on player start failure #16004

Merged
merged 1 commit into from
May 1, 2019

Conversation

arnova
Copy link
Member

@arnova arnova commented Apr 28, 2019

With v18 when a (video) item already has a resume bookmark set and the player fails to start (eg. NAS down / network problem) the item's resume bookmark will be cleared. Obviously this is not something most people want. It's also a regression from v17.

@arnova
Copy link
Member Author

arnova commented Apr 28, 2019

jenkins build this please

@iz8mbw
Copy link

iz8mbw commented Apr 28, 2019

Please, is it possible to apply this fix also to Kodi 19?

@arnova
Copy link
Member Author

arnova commented Apr 28, 2019

Yes, it will be backported to v19 as soon as it's merged in master.

@DaveTBlake
Copy link
Member

Yes, it will be backported to v19 as soon as it's merged in master.

@arnova wrong way around. The PR needs to be raised against master (v19) please, tagged with backport needed. Then a second PR raised for v18 tagged with backport, wait until v19 PR is merged before merging v18 one and finally once that is done edit tag on v19 PR to say backport-done

@fritsch fritsch added Backport: Needed Type: Fix non-breaking change which fixes an issue labels Apr 28, 2019
@arnova
Copy link
Member Author

arnova commented Apr 28, 2019

@DaveTBlake / @iz8mbw : This one IS against master (v19) ;-) Due to the confusion I said v19 where I meant v18 but thanks for the heads up :)

@DaveTBlake DaveTBlake added this to the M** 19.0-alpha 1 milestone Apr 28, 2019
@iz8mbw
Copy link

iz8mbw commented Apr 28, 2019

Happy to test it in the next nightly.

@iz8mbw
Copy link

iz8mbw commented Apr 29, 2019

When this PR will be merged?

@arnova
Copy link
Member Author

arnova commented Apr 29, 2019

jenkins build this please

@iz8mbw
Copy link

iz8mbw commented Apr 29, 2019

Jenk is sleeping :-)

@ksooo
Copy link
Member

ksooo commented Apr 29, 2019

Could you please stop spamming. Everytime you write here, many people get notified. So, please only speak up if you actually have something to say.

@arnova arnova merged commit db8e964 into xbmc:master May 1, 2019
@arnova arnova deleted the resume_bookmark_fix branch March 29, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport: Done Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants