Fix refresrate changing #16034
Fix refresrate changing #16034
Conversation
|
@lrusak okay with the added commit? |
Yes thanks :) I didn't realize that the the code was part of a revert initially Also, my 2 cents, I feel that the whitelist has become abused and turned into something it wasn't supposed to be (the catch all solution like we had before). The whole point of the whitelist was to add control and predictability to mode switching. I feel that we have lost this. I think we need to look at it again and take a look at all the possible problems with mode switching and what solutions are available. If we need to add an extra setting or some other custom controls then so be it. We cannot keep adding exceptions to the whitelist. |
|
I concurr here a bit. Whitelist: Add modes you like to switch to What exception do you see? |
|
After discussion with @peak3d I close this one. There is no sense in deciding between "half bullshittish solutions" and "40% bullshittish solutions". For Leia - please decide what the team likes best :-) |
During below additions the logic was flawed in a sense that 3:2 pulldown was evaluated too early. Means if you run at 60hz it would never switch to 24 hz and if you run at 59.94 hz it would never switch to 23.976, etc.
This reverts the mixed in logic, corrects the prints and uses the 3:2 as a final path.