Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keymap backport #16137

Merged
merged 2 commits into from
May 23, 2019
Merged

Keymap backport #16137

merged 2 commits into from
May 23, 2019

Conversation

Darren-Hill
Copy link
Contributor

@Darren-Hill Darren-Hill commented May 15, 2019

Backport of #16138

Adds two-finger right swipe for access to the blade menu on touchscreens.
Adds blade menu access through long right-click.
Adds right click as a way to exit the context menu without selecting anything.
@DaVukovic DaVukovic added Backport: Done Component: Input Type: Improvement non-breaking change which improves existing functionality v18 Leia labels May 15, 2019
@ksooo ksooo added this to the Leia 18.3-rc1 milestone May 15, 2019
@ksooo
Copy link
Member

ksooo commented May 15, 2019

As far as I know we only accept fixes for Leia codeline.

@Darren-Hill
Copy link
Contributor Author

Unless the skin used allows it with a button or something there's currently no way to access the blade menu on a touchscreen or with a mouse (only). Not sure if that would class as a fix or not.

If the decision is that it can only go into Matrix then no problem.

@ksooo
Copy link
Member

ksooo commented May 15, 2019

there's currently no way to access the

If it fixes something it should be fine for 18.x and ... it the PR should be flagged as Fix instead Improvement on github, then.

@ksooo ksooo added Type: Fix non-breaking change which fixes an issue and removed Type: Improvement non-breaking change which improves existing functionality labels May 15, 2019
@notspiff notspiff merged commit 6caed07 into xbmc:Leia May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Input Type: Backport Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants