New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PlaylistPlayer] Resolve plugin paths to fill the item infotag #16158
Conversation
I can confirm that this fixes #16151. |
@ksooo style issues addressed. 5 magic number explained in the comment. |
So, can this be merged now? |
Should we backport this to Leia? |
Sure, as the PR label "backport needed" already indicates. ;-) |
Didn't see that label all the way at the top! |
@basrieter can you backport? |
sure, I will git it a try. |
I created #16192 |
I have similar issue with Does this PR fix this issue ? (I initially think so, but I build kodi 20190604-75c1d6b3e7-dirty today from master and the issue is still there) Any chance to port his to player also (or json-rpc)? |
@bigretromike please open a separate issue with a clear description on how to reproduce the issue. Your comment seems totally unrelated to this PR. |
Description
When a
plugin://
path is played for the first time from the jsonrpc API, there is no information stored in the database for the item and it does not contain any music or video infotags (item->IsAudio() || item->IsVideo()
isfalse
). That makes Kodi interpret the item as a playlist (g_application.PlayMedia
) and information such as the item subtitles is not available. Users using remote control applications are not able to select the item provided subtitles. Subs will only be available the next time the item is played since at that moment the item info is already in the database and is filled byFillFileItemList
. This PR makes sure the plugin path is resolved before checking if it is audio or video, solving the issue.Motivation and Context
Fixes #16151
How Has This Been Tested?
With a proof of concept video plugin, changing the
plugin://
play path to make sure it is always an unknown path not in the db. Played the item via Kore remote app and checked the option to select subtitles was available.Types of change
Checklist: