[interfaces] Fix crash on Kodi exit caused by double freed AsyncCallbackMessage #16178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
added
Type: Fix
|
@MilhouseVH could you include this PR in your builds to get some feedback? |
|
Will do. |
|
No negative feedback from Milhouse users. Let's merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash during Kodi shutdown. Crash is caused by a dangling python addon callback message while descructing the global instance which holds the callback messages:
My suggestion for a fix is not to instanciate a Ref in
RetardedAsyncCallbackHandler::~RetardedAsyncCallbackHandler, but to use a raw pointer here.@jimfcarroll by any chance, if you are around, is this fix correct and acceptable?