PlatformDefs.h remove _MEMORYSTATUSEX struct #16181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrusak
added
Type: Cleanup
fuzzard
reviewed
May 21, 2019
yol
reviewed
May 22, 2019
|
rebase and squash |
jenkins4kodi
added
the
Rebase needed
jenkins4kodi
removed
the
Rebase needed
Rechi
reviewed
May 27, 2019
Rechi
reviewed
May 27, 2019
|
any objections? |
notspiff
reviewed
May 29, 2019
notspiff
reviewed
May 29, 2019
Rechi
reviewed
May 29, 2019
|
updated |
Rechi
approved these changes
May 30, 2019
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More PlatformDefs.h cleanup.
XMemUtils.hand then created a wrapper for these functions for windows._MEMORYSTATUSEXstruct from PlatformDefs.hI also cleaned up the linux memory method as we don't need to parse
/proc/meminfoI'm not sure if this is the best way (by just creating static methods in a namespace that share a common header) but I didn't see another way.
EDIT: I should also note that each commit builds individual (in sequence) but I only tested this on Linux and I don't expect them to build on windows in the same way. So if it's important to keep the build without breaking for each commit then I can squash them at the end,