CDRMUtils: explicitly set the caps we want (atomic brings them in) #16184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrusak
added
Type: Fix
|
ping @Kwiboo |
|
This works on my mainline rockchip testing, regarding 3D I guess GBM code may work with it, I no longer have easy access to a 3D TV to test on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DRM_CLIENT_CAP_ASPECT_RATIOexposes aspect ratio information to userspace. We don't handle this inKkodi so we shouldn't expose it because kodi will just see duplicate modes. This also caused an issue on my system where Kodi would use the wrong mode and caused a heavy modeset during startup.we can keep
DRM_CLIENT_CAP_STEREO_3Dbecause we do handle 3D modes in Kodi (though I've never tried 3D with GBM).CC @Kwiboo