[PVR] Separate GUI from PVR core: remove CFileItem usage from core #16213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tep 1.5: directory listings (forgot to remove one last occurence in step 1).
…tep 2: PVR core must not create new CFileItem instances.
…tep 3: No more CFileItem usage in 'channels'.
…tep 4: No more CFileItem usage in 'recordings'.
…tep 5: No more CFileItem usage in CPVRClient.
…tep 6: Some cleanup.
ksooo
added
Type: Cleanup
|
jenkins build this please |
Jalle19
approved these changes
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CFileItemand derived classes likeCFileItemListshould not be used in PVR core.CFileItemis derived fromCGUIListItemandAll this can lead to problems, mainly deadlocks and waste of system resources.
I carefully runtime-tested this changes on macOS and Android. No problems found.
@Jalle19 pleaes review. I tried to build logical units per commit.