[darwin/jenkins] - bump to xcode10.2 and its SDKs for tvos, ios and macOS #16218
Conversation
Memphiz
added
Type: Improvement
|
@lrusak this is the bump of clang |
|
@SylvainCecchetto this bumps Xcode for tvOS aswell fyi ... |
Very much appreciated!! 💯 |
|
Macos and iOS 32bit failed because one new warning is added by this PR - 64Bit iOS failed to build SQLite for some reason (tvOS did pass that which is odd cause it is arm64 aswell) |
|
Upped the warning limits for iOS and macOS as this PR does not contain any code changes but adds the warning because of compiler update - will investigate the SQLite problem for ios64 |
Just fix the warning. |
|
seems environment variables seem to be broken on jenkins ... while DEVELOPER_DIR is set correctly for Xcode 10.2 - all the toolchain stuff is used from Xcode 9.0 ... odd that this only fails arm64 ... tried it manually on the jenkins node and it properly switches xcode versions based on that DEVELOPER_DIR env var ... |
|
mhh works with bash - but doesn't work with sh (anymore?) thats what jenkins uses ... so at least i can reproduce it manually on the slave now ... now trying to figure out what it needs to make sh pass the env var to all child processes. |
|
No idea how - I don‘t even understand what that double reference parameter should mean in the method that throws the warning. If this should be a method that modifies the vector in place it should not have a return value at all. In the other case the copy might be intended and the warning has to be ignored or the intention has to be marked for the compiler somehow. |
|
I have fixed the Jenkins issue with the DEVELOPER_DIR env btw. ah can only „overwrite“ vars that are present - so the var needs to be initially injected in the Jenkins job (which was not the case for arm64) - Jenkins build this please for a proof. |
|
@Rechi did you reduce the allowed warnings again? I would have expected that the build would be ok now (yeah and I would have reduced the warning levels again afterwards) - can‘t look at the logs currently due to the shitty mobile phone grr |
|
Any chance can get another run on this with jenkins to see the logs. currently all the logs of the platforms return |
…an implicite copy - fixes new warning introduced with xcode bump (newer compiler)
|
@fuzzard i am on it ... pushed a commit that should remove that warning. Just need to ensure semantic is still correct. |
|
In place intention for the second commit was confirmed. |
|
armv7 builds crash on start after this has been merged... Tested on iPhone 5 with iOS 10.3.3. |
As the title says.
Bump to iOS SDK 12.2, tvOS SDK 12.2 and macOS SDK 10.14.
This is also the final fix for #14994 (full screen size for iPad Pro 11").