Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[webdav] allow http2 (fixes #16194) #16254

Merged
merged 1 commit into from Jun 11, 2019
Merged

[webdav] allow http2 (fixes #16194) #16254

merged 1 commit into from Jun 11, 2019

Conversation

wsnipex
Copy link
Member

@wsnipex wsnipex commented Jun 10, 2019

Description

see #16194

Motivation and Context

How Has This Been Tested?

briefly tested on linux

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@wsnipex wsnipex added Type: Fix non-breaking change which fixes an issue Backport: Needed Component: Network labels Jun 10, 2019
@wsnipex wsnipex requested a review from arnova June 10, 2019 09:15
arnova
arnova approved these changes Jun 10, 2019
View reviewed changes
Copy link
Member

@arnova arnova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Seems future proof enough (http3 ? ;-))

@wsnipex wsnipex mentioned this pull request Jun 11, 2019
Merged
13 tasks
@wsnipex wsnipex merged commit 1bd8f58 into xbmc:master Jun 11, 2019
@wsnipex wsnipex deleted the dav-http2 branch June 11, 2019 09:07
@Rechi Rechi added this to the Matrix 19.0-alpha 1 milestone Jun 11, 2019
@SOOTTV SOOTTV mentioned this pull request Jun 28, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnova arnova arnova approved these changes

Assignees
No one assigned
Labels
Backport: Done Component: Network Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
None yet
Milestone
Matrix 19.0-alpha 1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wsnipex @arnova @Rechi