Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix segfault when calling GetMemoryInfo #16279

Merged
merged 1 commit into from Jun 15, 2019
Merged

Conversation

peak3d
Copy link
Contributor

@peak3d peak3d commented Jun 15, 2019

Description

Trying to open PlayerInfo OSD currently lead to crash on android devices.

Motivation and Context

Fix segfault

How Has This Been Tested?

Run video, press o

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

@peak3d peak3d added Type: Fix non-breaking change which fixes an issue Component: Video Platform: Android v19 Matrix labels Jun 15, 2019
@peak3d peak3d added this to the Matrix 19.0-alpha 1 milestone Jun 15, 2019
@fritsch
Copy link
Member

fritsch commented Jun 15, 2019

This is broken on all other platforms as well.

@peak3d
Copy link
Contributor Author

peak3d commented Jun 15, 2019

Let me change the PR for the other platforms, too.
Edit: @fritsch I can only find this issue in android impl.:
https://github.com/xbmc/xbmc/blob/master/xbmc/platform/android/MemUtils.cpp#L42

@peak3d peak3d merged commit 668fbec into xbmc:master Jun 15, 2019
@peak3d peak3d deleted the meminfo branch June 15, 2019 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants