RPi: remove platform #16321

lrusak · 2019-06-28T17:09:39Z

Similar to #16043

To be clear for people. This does not remove support for the Raspberry Pi. It simply removes the RPi specific platform in Kodi. Raspberry Pi users can move to use GBM. The Raspberry Pi 4 will only ever use GBM and the older models can use it as well.

There as some things that aren't up to feature parity but it will be a level playing field for RPi, amlogic, rockchip, allwinner, etc. If someone submits improvements for one platform it will benefit all the platforms. That is the biggest reason for this removal.

This removal has been pushed off for some time now. I feel it is best to do this early in our V19 release cycle as to give other developers early warning that they will have to make changes to their development and OS's. This PR removes over 10,000 lines of platform specific code.

The entire goal of this (and what I have been working towards for over two years now) is to unify the code base into a more platform agnostic way. Developers are encouraged to move to GBM and ask as many questions as they would like about it.

Thanks to everyone that has made this possible so far. @popcornmix @6by9 @anholt @Kwiboo @chewitt and anyone else that I missed. There is still a lot to do but we will get there and when we do it will work on all platforms.

I am always available to answer any questions as they come up and can always be pinged in the #kodi-dev or #kodi-linux IRC rooms on freenode.

enen92 · 2019-06-28T18:37:05Z

xbmc/GUIInfoManager.cpp

@@ -1135,14 +1135,6 @@ const infomap weather[] =        {{ "isfetched",        WEATHER_IS_FETCHED },
 ///     @return **True** if Kodi is running on a linux/unix based computer.
 ///     <p>
 ///   }
-///   \table_row3{   <b>`System.Platform.Linux.RaspberryPi`</b>,


Can you add this to removed infolabels for v19? Search for "@skinning_v18 [Removed Infolabels] The following infolabels have been removed:" in this file

added, I hope I did that correctly!

graysky2 · 2019-06-29T10:48:54Z

I believe this PR would remove the RPi specific MAKEFLAGS for kodi and for ffmpeg thus removing the specific optimizations for at least those two components. Any way to allow for these?

For example:
https://github.com/xbmc/xbmc/pull/16321/files#diff-3127e7a36ef2ad9c5df64b48679c2899L45
https://github.com/xbmc/xbmc/pull/16321/files#diff-25bb87ae2148a0a2abba0a8a4296b5bfL416

lrusak · 2019-07-01T15:32:22Z

I believe this PR would remove the RPi specific MAKEFLAGS for kodi and for ffmpeg thus removing the specific optimizations for at least those two components. Any way to allow for these?

For example:
https://github.com/xbmc/xbmc/pull/16321/files#diff-3127e7a36ef2ad9c5df64b48679c2899L45
https://github.com/xbmc/xbmc/pull/16321/files#diff-25bb87ae2148a0a2abba0a8a4296b5bfL416

set your CFLAGS and CXXFLAGS in your env before building

graysky2 · 2019-07-01T18:43:20Z

set your CFLAGS and CXXFLAGS in your env before building

Yes, but I thought the the cmake scripts also passed some extra flags particularly for building ffmpeg.

lrusak · 2019-07-01T21:37:11Z

set your CFLAGS and CXXFLAGS in your env before building

Yes, but I thought the the cmake scripts also passed some extra flags particularly for building ffmpeg.

same answer

stefansaraev · 2020-01-13T20:50:08Z

this needs a rebase ;)

phunkyfish · 2020-03-09T12:53:34Z

@lrusak do you want to progress this?

lrusak · 2020-03-21T17:38:26Z

Yes this will continue to stay open.

docs/README.md

xbmc/guilib/guiinfo/GUIInfoLabels.h

xbmc/Application.cpp

garbear

diff looks good

popcornmix · 2020-09-06T19:04:40Z

I think you've removed AESinkPi.cpp/AESinkPi.h from the makefiles but not removed the files themselves.

lrusak · 2020-09-08T02:56:14Z

I think you've removed AESinkPi.cpp/AESinkPi.h from the makefiles but not removed the files themselves.

nice catch, probably lost in the rebase. Updated.

popcornmix

Look okay.

garbear · 2020-09-08T18:28:23Z

This is the 404 introduced by the README.RaspberryPi removal:

https://github.com/lrusak/xbmc/blob/rpi-removal/docs/README.RaspberryPi.md

I would suggest:

https://github.com/garbear/xbmc/blob/rpi-removal/docs/README.RaspberryPi.md

lrusak · 2020-09-08T19:47:07Z

https://github.com/garbear/xbmc/blob/rpi-removal/docs/README.RaspberryPi.md

Perfect thanks! I've updated it with this included.

garbear · 2020-09-08T19:51:39Z

Does the GBM build for raspberry pi require any pi-specific steps that should be mentioned in the linux readme?

lrusak · 2020-09-08T19:55:11Z

Does the GBM build for raspberry pi require any pi-specific steps that should be mentioned in the linux readme?

Not that I can think of. Users will have to use the VC4 DRM and mesa3d driver but using a DRM driver and a mesa3d driver are typical of any platform using GBM (other than some mali platforms). @popcornmix can you think of any other specifics that you would like to add?

popcornmix · 2020-09-09T11:13:08Z

I think it's okay. To run you need kms (dtoverlay=vc4-kms-v3d or dtoverlay=vc4-fkms-v3d) which is a default on Pi4 (but not earlier models).

I suspect users building themselves are familiar with this. If it seems to be a common issue I guess the
README.RaspberryPi.md stub could add it, or add it to the wiki (it's more an issue for running kodi than building it).

lrusak · 2020-09-09T18:13:04Z

@popcornmix your button 😊

graysky2 · 2020-10-03T12:06:54Z

Raspberry Pi users can move to use GBM. The Raspberry Pi 4 will only ever use GBM and the older models can use it as well.

I think it's okay. To run you need kms (dtoverlay=vc4-kms-v3d or dtoverlay=vc4-fkms-v3d) which is a default on Pi4 (but not earlier models). I suspect users building themselves are familiar with this. If it seems to be a common issue I guess the
README.RaspberryPi.md stub could add it, or add it to the wiki (it's more an issue for running kodi than building it).

@lrusak @popcornmix - If all Pis can in fact use gbm moving forward, what the default recommendations for:

RPi1
RPi2
RPi3
RPi4

Currently, for RPi4, I am using:

dtoverlay=vc4-kms-v3d-pi4,cma-size=402653184
dtoverlay=rpivid-v4l2

popcornmix · 2020-10-03T12:08:39Z

Use the forum for these questions.

graysky2 · 2020-10-03T12:17:53Z

https://forum.kodi.tv/showthread.php?tid=357454

Upstream dropped support for RPi platform since gbm matured and is stable[1]. This package should support RPi2+ hardware. 1. xbmc/xbmc#16321

lrusak added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Platform: Linux Platform: RPi v19 Matrix Type: Breaking change fix or feature that will cause existing functionality to change labels Jun 28, 2019

lrusak added this to the Matrix 19.0-alpha 1 milestone Jun 28, 2019

lrusak requested review from popcornmix and Rechi June 28, 2019 17:09

enen92 reviewed Jun 28, 2019

View reviewed changes

jenkins4kodi added the Rebase needed PR that does not apply/merge cleanly to current base branch label Jul 1, 2019

phunkyfish added the PR Cleanup: Ask Author PR appears to still be relevant and mergeable. Comment to author to check on status. label Mar 9, 2020

phunkyfish added PR Cleanup: Recent Checked as part of PR cleanup. PR has been followed up on recently. and removed PR Cleanup: Ask Author PR appears to still be relevant and mergeable. Comment to author to check on status. labels Mar 23, 2020

DaveTBlake modified the milestones: Matrix 19.0-alpha 1, Matrix 19.0-alpha 2 Jul 15, 2020

lrusak force-pushed the rpi-removal branch from ad7a424 to 1d861c8 Compare September 5, 2020 20:44

lrusak requested a review from garbear as a code owner September 5, 2020 20:44

garbear reviewed Sep 5, 2020

View reviewed changes

docs/README.md Show resolved Hide resolved

garbear reviewed Sep 5, 2020

View reviewed changes

xbmc/guilib/guiinfo/GUIInfoLabels.h Outdated Show resolved Hide resolved

garbear reviewed Sep 5, 2020

View reviewed changes

xbmc/Application.cpp Outdated Show resolved Hide resolved

garbear reviewed Sep 5, 2020

View reviewed changes

jenkins4kodi removed the Rebase needed PR that does not apply/merge cleanly to current base branch label Sep 5, 2020

lrusak force-pushed the rpi-removal branch from 1d861c8 to 0fbce05 Compare September 6, 2020 06:17

jenkins4kodi added the Rebase needed PR that does not apply/merge cleanly to current base branch label Sep 8, 2020

lrusak force-pushed the rpi-removal branch from 0fbce05 to 093a8fa Compare September 8, 2020 01:58

jenkins4kodi removed the Rebase needed PR that does not apply/merge cleanly to current base branch label Sep 8, 2020

popcornmix approved these changes Sep 8, 2020

View reviewed changes

lrusak requested review from enen92 and garbear September 8, 2020 17:44

RPi: remove platform

605b3b0

lrusak force-pushed the rpi-removal branch from 093a8fa to 605b3b0 Compare September 8, 2020 19:46

garbear approved these changes Sep 8, 2020

View reviewed changes

enen92 approved these changes Sep 8, 2020

View reviewed changes

popcornmix merged commit 811bd49 into xbmc:master Sep 9, 2020

HiassofT mentioned this pull request Sep 10, 2020

[strings] restore "Set GUI resolution limit" strings #18399

Merged

13 tasks

lrusak mentioned this pull request Oct 4, 2020

tools/depends: fix linux add-on build #18516

Merged

graysky2 added a commit to archlinuxarm/PKGBUILDs that referenced this pull request Dec 10, 2020

added alarm/kodi-rbp

143a744

Upstream dropped support for RPi platform since gbm matured and is stable[1]. This package should support RPi2+ hardware. 1. xbmc/xbmc#16321

mmtest1 mentioned this pull request Nov 1, 2021

Fin du support de Python 2 Kodi-vStream/venom-xbmc-addons#3397

Open

lrusak deleted the rpi-removal branch February 11, 2022 21:26

smp79 mentioned this pull request Dec 25, 2022

HEVC playback stutters since Kodi 19 on Raspberry Pi 2 and 3 - No problems with Kodi 18 #22315

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RPi: remove platform #16321

RPi: remove platform #16321

lrusak commented Jun 28, 2019

enen92 Jun 28, 2019

lrusak Sep 8, 2020

graysky2 commented Jun 29, 2019 •

edited

lrusak commented Jul 1, 2019 •

edited

graysky2 commented Jul 1, 2019

lrusak commented Jul 1, 2019

stefansaraev commented Jan 13, 2020

phunkyfish commented Mar 9, 2020

lrusak commented Mar 21, 2020

garbear left a comment

popcornmix commented Sep 6, 2020

lrusak commented Sep 8, 2020

popcornmix left a comment

garbear commented Sep 8, 2020

lrusak commented Sep 8, 2020

garbear commented Sep 8, 2020

lrusak commented Sep 8, 2020

popcornmix commented Sep 9, 2020

lrusak commented Sep 9, 2020

graysky2 commented Oct 3, 2020 •

edited

popcornmix commented Oct 3, 2020

graysky2 commented Oct 3, 2020

RPi: remove platform #16321

RPi: remove platform #16321

Conversation

lrusak commented Jun 28, 2019

enen92 Jun 28, 2019

Choose a reason for hiding this comment

lrusak Sep 8, 2020

Choose a reason for hiding this comment

graysky2 commented Jun 29, 2019 • edited

lrusak commented Jul 1, 2019 • edited

graysky2 commented Jul 1, 2019

lrusak commented Jul 1, 2019

stefansaraev commented Jan 13, 2020

phunkyfish commented Mar 9, 2020

lrusak commented Mar 21, 2020

garbear left a comment

Choose a reason for hiding this comment

popcornmix commented Sep 6, 2020

lrusak commented Sep 8, 2020

popcornmix left a comment

Choose a reason for hiding this comment

garbear commented Sep 8, 2020

lrusak commented Sep 8, 2020

garbear commented Sep 8, 2020

lrusak commented Sep 8, 2020

popcornmix commented Sep 9, 2020

lrusak commented Sep 9, 2020

graysky2 commented Oct 3, 2020 • edited

popcornmix commented Oct 3, 2020

graysky2 commented Oct 3, 2020

graysky2 commented Jun 29, 2019 •

edited

lrusak commented Jul 1, 2019 •

edited

graysky2 commented Oct 3, 2020 •

edited