Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PlayMedia builtin for smart playlists and playlists #16327

Merged
merged 1 commit into from Jul 29, 2019

Conversation

DaveTBlake
Copy link
Member

PlayMedia builtin is broken in v18 when called for a playlist or smart playlist that needs to be recursively expanded into actual media items e.g. a smart playlist of artist or albums. Reported in https://forum.kodi.tv/showthread.php?tid=344892

This regression was initially introduced by #11747 that ensured individual items are played with a playlist. It overlooked that item.IsVideo() returns true for .m3u and .xsp files and thus passed them to CPlayListPlayer::Play, which is unable to expand the .xsp file into the individual items to be queued, as if they were a single media file. Then #14183 attempted to fix the consequences - PlayMedia was not playing smart playlists and simple playlists are played as a single huge item. However this fix does not work for all smart playlists, they are not fully expanded and CPlayListPlayer::Play can not handle lists of artists or albums.

This fix restores the PlayMedia functionality for playlists and smartplaylists.

@DaveTBlake
Copy link
Member Author

@notspiff said he trusted me.... All testing, no point letting this languish here

@DaveTBlake DaveTBlake merged commit 55d75d9 into xbmc:master Jul 29, 2019
@DaveTBlake DaveTBlake deleted the PlayMediaBuiltinFix branch July 31, 2019 06:07
@Acidzero2020
Copy link
Contributor

Acidzero2020 commented Aug 5, 2019

@DaveTBlake
After this change i have the follow problem:
When I play a *.strm file from the widget (e.g. last viewed), the player does not display any information, see pictures.

The *.strm file calls an addon which only starts a video e.g:
listitem = xbmcgui.ListItem()
listitem.setPath( "http://184.72.239.149/vod/smil:BigBuckBunny.smil/playlist.m3u8")
xbmcplugin.setResolvedUrl(pluginhandle, True, listitem)

start:
start
before commit:
before
after commit:
after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants