Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] separate storage provider #16374

Merged

Conversation

kambala-decapitator
Copy link
Contributor

Description

Splits DarwinStorageProvider into OSX and iOS implementation and also adds free/total space display to iOS.

Motivation and Context

iOS didn't show anything in System info - Storage.

How Has This Been Tested?

  • built project for arm64 and ran on iOS device
  • verified that macOS code didn't become broken

Screenshots (if appropriate):

Screen Shot 2019-07-15 at 03 13 40

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@kambala-decapitator
Copy link
Contributor Author

Also a question here: would it be better to use already existing functions to get disk space: CSysInfo::GetDiskSpace (returns space in MB including used space and percents) or CSysInfo::GetHddSpaceInfo (already provides formatted strings, but requires calling it multiple times to get all the info)?

@jenkins4kodi jenkins4kodi added the Rebase needed PR that does not apply/merge cleanly to current base branch label Jul 18, 2019
@jenkins4kodi jenkins4kodi removed the Rebase needed PR that does not apply/merge cleanly to current base branch label Jul 24, 2019
@kambala-decapitator
Copy link
Contributor Author

Jenkins build this please

@jenkins4kodi jenkins4kodi added the Rebase needed PR that does not apply/merge cleanly to current base branch label Aug 15, 2019
@jenkins4kodi jenkins4kodi removed the Rebase needed PR that does not apply/merge cleanly to current base branch label Aug 15, 2019
@jenkins4kodi jenkins4kodi added the Rebase needed PR that does not apply/merge cleanly to current base branch label Sep 18, 2019
@jenkins4kodi jenkins4kodi removed the Rebase needed PR that does not apply/merge cleanly to current base branch label Oct 1, 2019
@kambala-decapitator kambala-decapitator added Type: Fix non-breaking change which fixes an issue v19 Matrix labels Oct 2, 2019
@kambala-decapitator kambala-decapitator merged commit 7c22008 into xbmc:master Oct 2, 2019
@kambala-decapitator kambala-decapitator deleted the ios-storage-provider branch October 2, 2019 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: iOS Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants