New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] separate storage provider #16374
Merged
kambala-decapitator
merged 2 commits into
xbmc:master
from
kambala-decapitator:ios-storage-provider
Oct 2, 2019
Merged
[iOS] separate storage provider #16374
kambala-decapitator
merged 2 commits into
xbmc:master
from
kambala-decapitator:ios-storage-provider
Oct 2, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also a question here: would it be better to use already existing functions to get disk space: |
notspiff
reviewed
Jul 15, 2019
kambala-decapitator
force-pushed
the
ios-storage-provider
branch
from
July 15, 2019 08:26
98dd689
to
f3b0408
Compare
notspiff
reviewed
Jul 15, 2019
kambala-decapitator
force-pushed
the
ios-storage-provider
branch
from
July 15, 2019 10:06
f3b0408
to
71f737b
Compare
Rechi
reviewed
Jul 16, 2019
kambala-decapitator
force-pushed
the
ios-storage-provider
branch
from
July 16, 2019 08:46
71f737b
to
78e7394
Compare
jenkins4kodi
added
the
Rebase needed
PR that does not apply/merge cleanly to current base branch
label
Jul 18, 2019
kambala-decapitator
force-pushed
the
ios-storage-provider
branch
from
July 24, 2019 22:11
78e7394
to
2390fe8
Compare
jenkins4kodi
removed
the
Rebase needed
PR that does not apply/merge cleanly to current base branch
label
Jul 24, 2019
Jenkins build this please |
kambala-decapitator
force-pushed
the
ios-storage-provider
branch
from
July 31, 2019 09:59
2390fe8
to
b151faa
Compare
jenkins4kodi
added
the
Rebase needed
PR that does not apply/merge cleanly to current base branch
label
Aug 15, 2019
kambala-decapitator
force-pushed
the
ios-storage-provider
branch
from
August 15, 2019 09:25
b151faa
to
7a69aab
Compare
jenkins4kodi
removed
the
Rebase needed
PR that does not apply/merge cleanly to current base branch
label
Aug 15, 2019
jenkins4kodi
added
the
Rebase needed
PR that does not apply/merge cleanly to current base branch
label
Sep 18, 2019
kambala-decapitator
force-pushed
the
ios-storage-provider
branch
from
October 1, 2019 17:43
7a69aab
to
62c63c7
Compare
jenkins4kodi
removed
the
Rebase needed
PR that does not apply/merge cleanly to current base branch
label
Oct 1, 2019
kambala-decapitator
added
Type: Fix
non-breaking change which fixes an issue
v19 Matrix
labels
Oct 2, 2019
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Splits
DarwinStorageProvider
into OSX and iOS implementation and also adds free/total space display to iOS.Motivation and Context
iOS didn't show anything in System info - Storage.
How Has This Been Tested?
Screenshots (if appropriate):
Types of change
Checklist: