Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PlaylistPlayer] Do not attempt to further resolve plugin paths for failing entries #16405

Merged
merged 1 commit into from Jul 31, 2019

Conversation

enen92
Copy link
Member

@enen92 enen92 commented Jul 26, 2019

Description

#16192 early resolved plugin paths so that the infotags are properly filled. However, even if a plugin fails to resolve, Kodi will continue trying to resolve it to a playable path in a 5 times loop. This PR fixes the behaviour returning early in case Kodi could not resolve the path. Thanks to @basrieter for the time.

@notspiff mind reviewing?

Motivation and Context

Fix #16385

How Has This Been Tested?

Runtime tested

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@notspiff
Copy link
Contributor

jenkins build this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening a plugin via JSON RPC keeps rerun the script only on 18.3
3 participants