[cmake] fix generating addon.xmls to avoid "file COPY" failures, fixes #16000

[MilhouseVH]

Description

See #16000 - this fixes the random "file COPY" failures when building Kodi.

Motivation and Context

Kodi failing randomly during a 3-4 hour (or longer) LibreELEC build is a PITA.

How Has This Been Tested?

Extensively, see #16000. I have performed several thousand Kodi builds without this commit (multiple failures observed), and several thousand Kodi builds with this commit (zero failures).

This change has been proposed by @wsnipex. I have removed the "retry" support from the original version as that seems to be unnecessary.

Screenshots (if appropriate):

N/A

Types of change

• Bug fix (non-breaking change which fixes an issue)
• Clean up (non-breaking change which removes non-working, unmaintained functionality)
• Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that will cause existing functionality to change)
• Cosmetic change (non-breaking change that doesn't touch code)
• None of the above (please explain below)

Checklist:

• My code follows the Code Guidelines of this project
• My change requires a change to the documentation, either Doxygen or wiki
• I have updated the documentation accordingly
• I have read the Contributing document
• I have added tests to cover my change
• All new and existing tests passed

[MilhouseVH]

@wsnipex looking at the native copy it excludes ".xml.in" which doesn't seem to be present in the external copy - should there be an attempt to delete addon.xml.in from the destination directory after the external copy (before the configure_file())?

[wsnipex]

Sadly there is no way I'm aware of to exclude the xml.in file directly, so we'd have to delete them after copy to retain the same behavior. Although keeping them doesn't harm

[MilhouseVH]

This seems to be working very well.

I don't want to tempt fate, but I've not had any "file COPY" related build failures since including this PR on 14 Aug, not even having switched back to using ninja which tended to make a "file COPY" failure more likely than plain cmake.

[wsnipex]

Looking at this again, I might have found the correct fix.
Can you please give wsnipex@275772b a try?

[MilhouseVH]

Thanks - I'll give a try and let you know (will take 3-4 days if it fixes the problem!)

[MilhouseVH]

@wsnipex successfully completed 3,000 Kodi builds with wsnipex@275772b, and zero failures. I've updated this PR with the revised commit.

[wsnipex]

please add wsnipex@3a539dd to hopefully fix the windows build failures

edit: and please adjust the PR title, while you're at it

[MilhouseVH]

please add wsnipex/xbmc@3a539dd to hopefully fix the windows build failures

Done.

edit: and please adjust the PR title, while you're at it

Not really sure what the title should be now, hopefully that's correct?

[Rechi]

The commits have to be squashed or interchanged as it otherwise breaks bisecting on windows.

[MilhouseVH]

Squashed.

[wsnipex]

Thanks for your patience and all the testing