Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[depends] build libplist static #16503

Merged
merged 1 commit into from Aug 23, 2019
Merged

[depends] build libplist static #16503

merged 1 commit into from Aug 23, 2019

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Aug 18, 2019

Description

build libplist static

Motivation and Context

libplist didn't link math lib, which caused errors on some android devices, after #16167

cannot locate symbol "modf" referenced by "libplist.so"

How Has This Been Tested?

tested by the user who reported the crash

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi Rechi added Type: Fix non-breaking change which fixes an issue Component: Depends v19 Matrix labels Aug 18, 2019
@Rechi Rechi added this to the Matrix 19.0-alpha 1 milestone Aug 18, 2019
@Rechi Rechi requested a review from wsnipex August 18, 2019 07:38
@Rechi Rechi force-pushed the depends/plist branch 3 times, most recently from f044808 to 47a3bee Compare August 21, 2019 06:06
@Rechi
Copy link
Member Author

Rechi commented Aug 23, 2019

@wsnipex ping

@Rechi Rechi merged commit d8e34a1 into xbmc:master Aug 23, 2019
@Rechi Rechi deleted the depends/plist branch August 23, 2019 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Depends Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants