fixed: Use exact matching for protocol in file+dir factories (fixes vfs.sftp addon issue #37) #16511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnova
added
Type: Fix
|
split fix is correct, i disagree on the prefering internals - that voids the ability to override implementations. |
Yes I already had doubts about this. Overriding internals may be useful but obviously this comes with the downside that you can completely screw up your setup when you install a broken (or malicious) addon. I don't mind changing it so that it prefers addons as long as it's consistent (which it previously wasn't in File vs. Dir factory) |
arnova
force-pushed
the
protocol_factory_fix
branch
from
bcfa897
to
3af7d85
Compare
…fs.sftp addon issue xbmc#37) changed: Consistently prefer addon protocols over internal protocols
arnova
force-pushed
the
protocol_factory_fix
branch
from
3af7d85
to
9e9d81c
Compare
|
@notspiff : Updated |
AlwinEsch
approved these changes
Aug 19, 2019
|
@notspiff : Ok, as is? |
notspiff
approved these changes
Aug 23, 2019
|
jenkins build this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we did not use an exact match to compare the protocol in file/dir factory causing eg. "ftp" to be matched in "sftp". Furthermore we weren't consistent preferring internally supported protocols over addon provided protocols.
This fixes xbmc/vfs.sftp#37