Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[depends] bump flatbuffers to 1.11.0 #16527

Merged
merged 1 commit into from
Sep 2, 2019
Merged

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Aug 24, 2019

How Has This Been Tested?

compiled flatbuffers for Android (aarch64, arm, i686), iOS (aarch64, arm), Linux, macOS and tvOS

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi
Copy link
Member Author

Rechi commented Sep 2, 2019

@wsnipex ping

@Rechi Rechi merged commit 7405d26 into xbmc:master Sep 2, 2019
@Rechi Rechi deleted the depends/flatbuffers branch September 2, 2019 15:30
@stsichler
Copy link
Contributor

Argh. I was sure that the build was clean, but it seems it actually wasn't.
Sorry.
I'll give it another try and report back.

@stsichler
Copy link
Contributor

Works! :-)
Thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants