Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[addons] use on build in binary addons only library="dummy.so" #16531

Merged
merged 1 commit into from Aug 30, 2019

Conversation

AlwinEsch
Copy link
Member

Description

This is intended to avoid OS related problems when Kodi is built on an unknown OS.

Related to 0833902

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

This is intended to avoid OS related problems when Kodi is built on an unknown OS.
@AlwinEsch AlwinEsch added Type: Fix non-breaking change which fixes an issue Component: Binary add-ons v19 Matrix labels Aug 26, 2019
@AlwinEsch AlwinEsch added this to the Matrix 19.0-alpha 1 milestone Aug 26, 2019
@AlwinEsch AlwinEsch requested a review from Hitcher August 26, 2019 05:22
@Hitcher
Copy link
Contributor

Hitcher commented Aug 26, 2019

Above my paygrade unfortunately.

@AlwinEsch
Copy link
Member Author

jenkins build this please

@AlwinEsch
Copy link
Member Author

Why does jenkins not build there?

@Rechi
Copy link
Member

Rechi commented Aug 30, 2019

Jenkins doesn't build PRs which only change files in addons and a few other folders.

@AlwinEsch AlwinEsch merged commit 2fbc36b into xbmc:master Aug 30, 2019
@AlwinEsch AlwinEsch deleted the change-buildin branch August 30, 2019 12:25
@AlwinEsch
Copy link
Member Author

@Rechi, OK 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Binary add-ons Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants