[addons][inputstream] allow instance version check and fix inputstream addon way #16535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlwinEsch
added
Component: Binary add-ons
Type: Fix
|
Is this the fix for xbmc/inputstream.adaptive#313 ? |
|
Seems to be connected because of your given commit examples this way came. |
…eck depends) By this also the "CAddon::GetDependencyVersion(..,)" is changed to, and CBinaryAddonBase becomes it added too, to have on running instances.
Before was the addon own version used where never match a inputstream instance version.
AlwinEsch
force-pushed
the
allow-instance-version-check
branch
from
980f4fa
to
4142840
Compare
|
@candrews yes |
peak3d
approved these changes
Aug 28, 2019
|
Confirmed also that it fixed my problem. Thank you! |
|
Why was this merged with a failed Jenkins build? |
|
The test was OK, only by Win64 on end a jenkins build script failure EDIT: Also as another was Win32 and Win64 UWP complete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The fist commit:
[addons] add new function "CAddonInfo::DependencyVersion(...)" (to check depends)
By this also the "CAddon::GetDependencyVersion(..,)" is changed to, and
CBinaryAddonBase becomes it added too, to have on running instances.
The second commit:
[addons][inputstream] fix depedency version check
Before was the addon own version used where never match a inputstream instance
version.
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of change
Checklist: