Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Inputstream Addon] Add missing breaks #16545

Merged
merged 1 commit into from
Aug 30, 2019
Merged

[Inputstream Addon] Add missing breaks #16545

merged 1 commit into from
Aug 30, 2019

Conversation

peak3d
Copy link
Contributor

@peak3d peak3d commented Aug 30, 2019

Description

This PR adds missing breaks when evaluating VP9 codec profile for playback with AddonVideoCodec (e.g. DRM protected / secured content using widevine shared library)

Motivation and Context

Coverity scan report

How Has This Been Tested?

not tested

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

@peak3d peak3d added Type: Fix non-breaking change which fixes an issue Component: Binary add-ons v19 Matrix labels Aug 30, 2019
@peak3d peak3d added this to the Matrix 19.0-alpha 1 milestone Aug 30, 2019
ksooo
ksooo approved these changes Aug 30, 2019
View reviewed changes
Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AlwinEsch AlwinEsch self-requested a review August 30, 2019 12:28
@ksooo
Copy link
Member

ksooo commented Aug 30, 2019

jenkins build this please

@peak3d peak3d merged commit e04050a into xbmc:master Aug 30, 2019
@peak3d peak3d deleted the vp9hdrfix branch August 30, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksooo ksooo ksooo approved these changes

@AlwinEsch AlwinEsch AlwinEsch approved these changes

Assignees
No one assigned
Labels
Component: Binary add-ons Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
None yet
Milestone
Matrix 19.0-alpha 1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peak3d @ksooo @AlwinEsch