Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Update build (4.1 -> 5.4.1) and SDK (26 -> 28) versions #16559

Merged
merged 1 commit into from
Sep 3, 2019

Conversation

peak3d
Copy link
Contributor

@peak3d peak3d commented Sep 2, 2019

Description

Update gradle : 5.4.1
Update Android SDK: 28
Update build-tools: 28.0.3

Motivation and Context

Beginning from 2019/11 Playstore does not supports apks with targetSDKVersion < 28.

How Has This Been Tested?

Build arm (32-bit) apk

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

@peak3d
Copy link
Contributor Author

peak3d commented Sep 2, 2019

Jenkins build this please

@Rechi
Copy link
Member

Rechi commented Sep 2, 2019

Which android versions was this tested with?

Edit: Have you read the documentation? Are there any code changes required?

@peak3d
Copy link
Contributor Author

peak3d commented Sep 2, 2019

@Rechi NVIDIA shield TV with SDK 28, and AFTV with SDK 25

@peak3d peak3d merged commit cdcabff into xbmc:master Sep 3, 2019
@peak3d peak3d deleted the sdkversion branch September 3, 2019 20:17
peak3d added a commit to peak3d/xbmc that referenced this pull request Oct 9, 2019
[Android] Update build (4.1 -> 5.4.1) and SDK (26 -> 28) versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants