Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pvr coverity #16568

Merged
merged 2 commits into from Sep 4, 2019
Merged

Pvr coverity #16568

merged 2 commits into from Sep 4, 2019

Conversation

phunkyfish
Copy link
Contributor

Description

Fix for Coverity warning and some refactoring

Motivation and Context

Coverity raised an issue.

How Has This Been Tested?

Using pvr.iptvsimple

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@phunkyfish
Copy link
Contributor Author

@ksooo, wasn't sure if I should line up the comments for the initialisers or not. Let me know.

Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@phunkyfish phunkyfish added Component: PVR Type: Fix non-breaking change which fixes an issue Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v19 Matrix labels Sep 4, 2019
@phunkyfish phunkyfish added this to the Matrix 19.0-alpha 1 milestone Sep 4, 2019
@phunkyfish phunkyfish merged commit 8b45479 into xbmc:master Sep 4, 2019
@phunkyfish phunkyfish deleted the pvr-coverity branch September 4, 2019 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PVR Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants