Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[modernize] readability-redundant-smartptr-get #16573

Merged
merged 1 commit into from Sep 5, 2019
Merged

[modernize] readability-redundant-smartptr-get #16573

merged 1 commit into from Sep 5, 2019

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Sep 5, 2019

Description

run clang-tidy readability-redundant-smartptr-get check and applied the suggested fixes

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi Rechi added Type: Improvement non-breaking change which improves existing functionality v19 Matrix labels Sep 5, 2019
@Rechi Rechi added this to the Matrix 19.0-alpha 1 milestone Sep 5, 2019
notspiff
notspiff reviewed Sep 5, 2019
View reviewed changes
Copy link
Contributor

@notspiff notspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave up commenting on all of them, but there should be one comment per affected file.

xbmc/cdrip/CDDARipper.cpp Outdated Show resolved Hide resolved
xbmc/dbwrappers/Database.cpp Outdated Show resolved Hide resolved
xbmc/dbwrappers/Database.cpp Outdated Show resolved Hide resolved
xbmc/dbwrappers/Database.cpp Outdated Show resolved Hide resolved
xbmc/dbwrappers/Database.cpp Outdated Show resolved Hide resolved
xbmc/pictures/GUIWindowPictures.cpp Outdated Show resolved Hide resolved
xbmc/playlists/PlayListPLS.cpp Outdated Show resolved Hide resolved
xbmc/video/VideoDatabase.cpp Outdated Show resolved Hide resolved
xbmc/view/ViewDatabase.cpp Outdated Show resolved Hide resolved
xbmc/windows/GUIWindowFileManager.cpp Outdated Show resolved Hide resolved
@Rechi Rechi force-pushed the modernize/readability-redundant-smartptr-get branch from 425f4f0 to 25cc1cd Compare September 5, 2019 10:14
@Rechi
Copy link
Member Author

Rechi commented Sep 5, 2019

run clang-tidy-diff with modernize-use-nullptr check

@Rechi Rechi merged commit df4baf4 into xbmc:master Sep 5, 2019
@Rechi Rechi deleted the modernize/readability-redundant-smartptr-get branch September 5, 2019 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notspiff notspiff notspiff left review comments

Assignees
No one assigned
Labels
Type: Improvement non-breaking change which improves existing functionality v19 Matrix
Projects
None yet
Milestone
Matrix 19.0-alpha 1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rechi @notspiff