Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump androidjni sha (fix Display::isHdr() #16579

Merged
merged 1 commit into from Sep 7, 2019
Merged

bump androidjni sha (fix Display::isHdr() #16579

merged 1 commit into from Sep 7, 2019

Conversation

peak3d
Copy link
Contributor

@peak3d peak3d commented Sep 6, 2019

Description

Set libandroidjni SHA to current master HEAD

Motivation and Context

Android kodi aarch64 version currently segfaults with "method not found" exception because of wrong signature of the return type in Display::isHdr.
This PR forces current libandroidjni HEAD which solves the issue.

How Has This Been Tested?

  • Start kodi on e.g. NVIDIA Shield TV with aarch64 kodi.
  • Play a movie with HDR information or open player video settings section.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches latest landroidjni commit.

@CiNcH83
Copy link

CiNcH83 commented Sep 8, 2019

The isHdr call seems to work on BRAVIA:
08:53:26.035 T:2487245168 DEBUG: CAndroidUtils: IsHDRDisplay: true

Kodi menu/OSD (also including artworks) colors and luminance are still wrong though when playing HDR videos (using MediaCodec Surface).

@fritsch
Copy link
Member

fritsch commented Sep 8, 2019

Menu / OSD: is wrong whenever you do any HDR. No one cared for that ... Subs should also be fully off by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants