[iOS] - Implement CNetworkIOS implementation for darwin_embedded platforms #16607
Conversation
fuzzard
force-pushed
the
ios_network
branch
6 times, most recently
from
960eb0b
to
26d66b9
Compare
|
I believe this is in its final state now. Have set a priority ordering for return of GetFirstinterfaceConnected to be VPN->Wifi->Cell. System information now updates ip/dns/gateway with consistent info on network changes, and works across both ipv4/ipv6 networks. Hoping i can now get a full jenkins build Jenkins build this please |
|
Jenkins build this please |
fuzzard
force-pushed
the
ios_network
branch
2 times, most recently
from
4a25058
to
8980ba6
Compare
fuzzard
force-pushed
the
ios_network
branch
from
8980ba6
to
e204a4e
Compare
fuzzard
force-pushed
the
ios_network
branch
2 times, most recently
from
36a5e88
to
455bf0e
Compare
|
Ok, cleaned up a few more, fixed up a malloc crash that was occurring with the first iteration as well. Jenkins build this please |
|
Todo's added as requested. This rework has also been confirmed to fix the issue noted on the forums |
jenkins4kodi
added
the
Rebase needed
jenkins4kodi
removed
the
Rebase needed
fuzzard
changed the title
|
Have updated PR/commit messages. Please note, this does fix a reported bug in Leia, however i do not intend to backport. I believe the change is too large, and although i do not believe there are any regressions, i dont particularly want to handle it if something does come up in leia. Any further changes required to get this in? |
|
jenkins build this please |
|
Caught a crash while running on iPad Air 2 with iOS 13.1.2. Last lines of stack trace: CSysInfoJob::DoWork() (in Kodi) (SystemInfo.cpp:256) Full log: Kodi 03-10-2019, 10-32.crash.txt |
|
I think that |
|
No, why do you think so? |
|
In Memphiz's original PR this was based off, it was raised the question about if there were any platforms that were not covered by that ifdef. I would guess its more likely that we remove the ifdef completely |
|
Removing the whole ifdef could be possible, but I read your previous comment that you only want to remove |
|
we know beforehand that iOS::GetMAC() returns an empty string, so why do useless work by retrieving interface and then get the very same result? I'd just make a shortcut and leave a todo. |
|
No, SystemInfo doesn't have to know anything about the implementation details of |
|
Every default platform is covered by that ifdef (android, freebsd, osx, linux = linux_network, win is win, then ios.) Do you want the ifdef removed in a separate commit? |
|
As the ifdef currently is true for everything, sure. |
|
Have added a separate commit removing that ifdef. Have a look and let me know if you want it done a different way (ie remove the else and just have the return ""; as the fall through). Jenkins keeps giving me empty builds, so hoping this request will work. jenkins build this please |
jenkins4kodi
added
the
Rebase needed
|
There is nothing in the Kodi coding standard which allows or disallows else statements after return. I personally wouldn't have added the else. |
jenkins4kodi
removed
the
Rebase needed
|
jenkins build this please |
|
Any further comments? I'll look to merge it in the next 24hrs if all ok. |
|
Please rebase and use the new formatting rules of #16701. |
Ifdef was always true for all current platforms, making it redundant.
…menation Removes darwin_embedded network implementation from standard posix network implementation Handles all CNetworkBase overloads specific to darwin_embedded platforms. As of ios11, it is not possible to retrieve interface MAC addresses, or to retrieve info from the devices ARP table. WOL/WakeOnAccess features are not possible without these. MAC address access was actually deprecated in ios7.
|
Nice work thx :) |
Description
This fixes/extends Memphiz's previous PR #14344
Have relocated files to ios-common, as the intent will be for it to be used for tvos as well.
This also enables ipv6 functionality for those network functions
Note: iOS does NOT allow the finding of mac address for interfaces. This was deprecated in ios7, with a hard OS change in ios 11. The method that did work in ios7-10 was to look at the arp table, but apple now hijack this, and return 02:00:00:00:00:00. Decision was made to just return empty string.
This also means that GetHostMacAddress() is not able to be implemented for WOL. With that change, there is no longer a need for the ioshacks.h header (was only used for mac address functionality)
The implementation also fixes a reported issue from the forums - https://forum.kodi.tv/showthread.php?tid=341593&pid=2888545#pid2888545
Motivation and Context
Saw a forum post with a user being a bit of a jerk. In spite of that, thought id get memphiz's PR up to the current state, and have cleaned up a bit more.
How Has This Been Tested?
ipad -> sys info responds with updating ip/dns/gateway correctly on network change
iphone -> tested on wifi/cell with both ipv4/6, and info updates correctly
Screenshots (if appropriate):
Types of change
Checklist: