Reduce log spam produced by AnnouncementManager #16651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveTBlake
added
Type: Cleanup
DaveTBlake
force-pushed
the
LogSpamFix
branch
2 times, most recently
from
7ce614b
to
ccfb887
Compare
As I said on Slack: Put into Leia whatever you want. I will refrain from commenting. |
ksooo
reviewed
Sep 23, 2019
DaveTBlake
force-pushed
the
LogSpamFix
branch
from
ccfb887
to
5d2c43d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got fed up with
CAnnouncementManagercluttering up the debug log withThe number of entries depending on how many listeners registered, and bulked up debug of library scanning to no good use. But in case the logging was of use to some dev at a later point I have added a level of component logging for Annoucements and moved the log calls to that component.
I would like to backport too - removing log spam is useful for anyone looking at logs regualrly, low risk, and not a new feature to "sell" later to users. @ksooo what do you think?