Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[depends] bump libbluray to 1.1.2 #16665

Merged
merged 1 commit into from Oct 6, 2019
Merged

[depends] bump libbluray to 1.1.2 #16665

merged 1 commit into from Oct 6, 2019

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Sep 23, 2019

Description

  • bump libbluray to version 1.1.2
  • build static
  • enable metadata support (libxml2)
  • enable font support (freetype2)
  • add fontconfig dependency

How Has This Been Tested?

compiled libbluray and it's dependencies for Android (aarch64, arm, i686), iOS (aarch64, arm), Linux, macOS and tvOS
compiled Kodi for iOS (aarch64, arm) and macOS

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi Rechi added this to the Matrix 19.0-alpha 1 milestone Sep 23, 2019
@Rechi Rechi requested a review from wsnipex September 23, 2019 20:47
@da-anda
Copy link
Member

da-anda commented Sep 24, 2019

does this one need runtime testing? IIRC a forum user mentioned that we might need some core changes to be compatible with a new/changed API for BDJ menus

@MilhouseVH
Copy link
Contributor

@da-anda I believe that was with libbluray 1.2: #16331

@da-anda
Copy link
Member

da-anda commented Sep 25, 2019

right, my bad.

@fandangos
Copy link
Contributor

I really want to proper implement this on Windows with java enabled. I see that the android version uses the source and cmake compiles it.
Windows version 1.0.2 has the includes, lib and bin files in a package.

What is the correct way of updating the windows libbluray? Just compiling dll, the lib and adding the includes? What else needs to be changed?
Or how different from this would be bumping windows to libbluray 1.1.2?

@Rechi
Copy link
Member Author

Rechi commented Oct 5, 2019

@wsnipex ping

@Rechi
[depends] bump libbluray to 1.1.2
619e559 
- build static
- enable metadata support (libxml2)
- enable font support (freetype2)
- add fontconfig dependency
@Rechi Rechi merged commit d5daebb into xbmc:master Oct 6, 2019
@Rechi Rechi deleted the depends/libbluray branch October 6, 2019 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsnipex wsnipex wsnipex approved these changes

Assignees
No one assigned
Labels
Component: Depends v19 Matrix
Projects
None yet
Milestone
Matrix 19.0-alpha 1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Rechi @da-anda @MilhouseVH @fandangos @wsnipex