Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for xcode 11 #16668

Merged
merged 1 commit into from Sep 25, 2019
Merged

add support for xcode 11 #16668

merged 1 commit into from Sep 25, 2019

Conversation

tmm1
Copy link
Contributor

@tmm1 tmm1 commented Sep 23, 2019

Description

the output of xcodebuild -showsdks after upgrading to xcode 11 is:

$ xcodebuild -showsdks
iOS SDKs:
	iOS 13.0                      	-sdk iphoneos13.0

iOS Simulator SDKs:
	Simulator - iOS 13.0          	-sdk iphonesimulator13.0

macOS SDKs:
	DriverKit 19.0                	-sdk driverkit.macosx19.0
	macOS 10.15                   	-sdk macosx10.15

tvOS SDKs:
	tvOS 13.0                     	-sdk appletvos13.0

tvOS Simulator SDKs:
	Simulator - tvOS 13.0         	-sdk appletvsimulator13.0

watchOS SDKs:
	watchOS 6.0                   	-sdk watchos6.0

watchOS Simulator SDKs:
	Simulator - watchOS 6.0       	-sdk watchsimulator6.0

@fuzzard
Copy link
Contributor

fuzzard commented Sep 23, 2019

can i suggest possibly changing found_sdk search to the following.

found_sdk_version=[`$use_xcodebuild -showsdks | grep macosx | sort | tail -n 1 | awk '{ print $2}'`]

Also, may be worthwile updating the ios/tvos while your in their. Again, up to you really.
Just need to add a 13.*);; after the following two lines


Copy link
Contributor

@fuzzard fuzzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, cheers

@ksooo
Copy link
Member

ksooo commented Sep 25, 2019

jenkins build this please

@ksooo ksooo merged commit 4e8f965 into xbmc:master Sep 25, 2019
@Rechi
Copy link
Member

Rechi commented Sep 26, 2019

@ksooo please always set the milestone before or right after merging a PR.

@ksooo ksooo added this to the Matrix 19.0-alpha 1 milestone Sep 26, 2019
@ksooo
Copy link
Member

ksooo commented Sep 26, 2019

Ooops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants