[modernize] use-equals-default

[Rechi]

Description

run clang-tidy modernize-use-equals-default and applied the suggested fixes

Types of change

• Bug fix (non-breaking change which fixes an issue)
• Clean up (non-breaking change which removes non-working, unmaintained functionality)
• Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that will cause existing functionality to change)
• Cosmetic change (non-breaking change that doesn't touch code)
• None of the above (please explain below)

Checklist:

• My code follows the Code Guidelines of this project
• My change requires a change to the documentation, either Doxygen or wiki
• I have updated the documentation accordingly
• I have read the Contributing document
• I have added tests to cover my change
• All new and existing tests passed

[ksooo]

Moving default/empty ctors/dtors/... from cpp to h can have side effects (compiler errors), because you make the ctors/dtors/... inline with this.

[notspiff]

yes, it can have consequences, in particular if you have forwarded members.

[ksooo]

What I said! Look at Jenkins' state.

[ksooo]

14:34:31 /Applications/Xcode10.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:2331:19: error: invalid application of 'sizeof' to an incomplete type 'ADDON::CBinaryAddonCache'
14:34:31     static_assert(sizeof(_Tp) > 0,
14:34:31                   ^~~~~~~~~~~
14:34:31 /Applications/Xcode10.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:2648:7: note: in instantiation of member function 'std::__1::default_delete<ADDON::CBinaryAddonCache>::operator()' requested here
14:34:31       __ptr_.second()(__tmp);
14:34:31       ^
14:34:31 /Applications/Xcode10.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:2602:19: note: in instantiation of member function 'std::__1::unique_ptr<ADDON::CBinaryAddonCache, std::__1::default_delete<ADDON::CBinaryAddonCache> >::reset' requested here
14:34:31   ~unique_ptr() { reset(); }
14:34:31                   ^
14:34:31 /Users/Shared/jenkins/workspace/OSX-64/xbmc/ServiceManager.h:77:3: note: in instantiation of member function 'std::__1::unique_ptr<ADDON::CBinaryAddonCache, std::__1::default_delete<ADDON::CBinaryAddonCache> >::~unique_ptr' requested here
14:34:31   CServiceManager() = default;
14:34:31   ^
14:34:31 /Users/Shared/jenkins/workspace/OSX-64/xbmc/ServiceBroker.h:16:7: note: forward declaration of 'ADDON::CBinaryAddonCache'
14:34:31 class CBinaryAddonCache;

I dont think it is good to include the header for CBinaryAddonCache in ServiceBroker.h.
I opt for CServiceManager ctor declaration in header and definition as default in cpp.

[notspiff]

i totally agree, if the c/dtor need to be in cpp to avoid includes, that's what you do. just, if there is no reason, i prefer to see it in the header (cause that's what i look at to study classes, and the indirection to find = default in the cpp is then confusing (i expect an implementation in that case).

[ksooo]

if the c/dtor need to be in cpp to avoid includes, that's what you do.

+1

just, if there is no reason, i prefer to see it in the header

+1

[Rechi]

@ksooo @notspiff it now compiles on all platforms. I've moved the constructors and destructors back to the cpp files where it was required.

Is this now okay to get merged, after squashing?

[ksooo]

Is this now okay to get merged, after squashing?

Fine by me.

[notspiff]

Do it.