[pvr] refactoring - review fixup after merge of 16677 #16680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phunkyfish
added
Type: Cleanup
13 tasks
Rechi
reviewed
Sep 27, 2019
| std::shared_ptr<CPVRClients> m_addons; /*!< pointer to the pvr addon container */ | ||
| std::unique_ptr<CPVRGUIInfo> m_guiInfo; /*!< pointer to the guiinfo data */ | ||
| std::shared_ptr<CPVRGUIActions> m_guiActions; /*!< pointer to the pvr gui actions */ | ||
| CPVREpgContainer m_epgContainer; /*!< the epg container */ |
There was a problem hiding this comment.
comments are still vertical aligned
| std::shared_ptr<CPVRDatabase> m_database; /*!< the database for all PVR related data */ | ||
| mutable CCriticalSection m_critSection; /*!< critical section for all changes to this class, except for changes to triggers */ | ||
| bool m_bFirstStart = true; /*!< true when the PVR manager was started first, false otherwise */ | ||
| bool m_bEpgsCreated = false; /*!< true if epg data for channels has been created */ |
There was a problem hiding this comment.
comments are still vertical aligned
| std::vector<std::shared_ptr<CPVRChannelGroup>> m_groups; /*!< the groups in this container */ | ||
| bool m_bRadio; /*!< true if this is a container for radio channels, false if it is for tv channels */ | ||
| std::shared_ptr<CPVRChannelGroup> m_selectedGroup; /*!< the group that's currently selected in the UI */ | ||
| std::vector<std::shared_ptr<CPVRChannelGroup>> m_groups; /*!< the groups in this container */ |
There was a problem hiding this comment.
comments are still vertical aligned
| mutable CDateTime m_nowActiveStart; /*!< the start time of the tag that is currently active */ | ||
| CDateTime m_lastScanTime; /*!< the last time the EPG has been updated */ | ||
| mutable CCriticalSection m_critSection; /*!< critical section for changes in this table */ | ||
| bool m_bUpdateLastScanTime = false; |
There was a problem hiding this comment.
comments are still vertical aligned
| std::shared_ptr<CPVRTimerType> m_timerType; /*!< the type of this timer */ | ||
| CDateTime m_StartTime; /*!< start time */ | ||
| CDateTime m_StopTime; /*!< stop time */ | ||
| CDateTime m_FirstDay; /*!< if it is a manual timer rule the first date it starts */ |
There was a problem hiding this comment.
comments are still vertical aligned
|
I suggest to fix the "comments are still vertical aligned" issues in a follow-up PR - for the whole PVR component. |
|
Fair, I’ll make the other changes later today. |
phunkyfish
force-pushed
the
pvr-16677-fiuxp
branch
from
29e74cb
to
3d297b4
Compare
|
Ok, should be ready. |
ksooo
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixup for #16677 for review after it was merged.
No functional change
Motivation and Context
How Has This Been Tested?
OSX, latest Alpha.
Screenshots (if appropriate):
Types of change
Checklist: