-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PulseAudio: Implement DTS-HD and TrueHD #16693
base: master
Are you sure you want to change the base?
Conversation
|
@tanuk @ford-prefect Any idea how these new formats should be probed and work? |
Hey @fritsch! Unfortunately, I missed landing a bunch of requried changes before announcing DTS-HD/Dolby TrueHD support. The required work is here -- https://gitlab.freedesktop.org/pulseaudio/pulseaudio/merge_requests/24 I also missed adding that to pavucontrol for an easier way to enable it, so quite poor showing all around, sorry about that. |
Thanks much @ford-prefect - we are in no hurry here as next major Ubuntu will ship 13.0 only. Do you plan to add those fixed to 13.1? I would then change the patchset to only enable it for 13,1,0 Codewise it's okay? So nothing fancy, just: 192 khz + 16bit + 8 channels + HD-Format? One thing to add: Modern AVRs don't consume DTS-HD HR anymore with 8 channels 192 khz, for those we changed our IEC encoder to also send 2 channels / 192 khz, while DTS-HD MA will still be sent as 8/192 khz. Is that something PA might also need to do? |
cf9929e
to
2803c5c
Compare
Patch for PA and DTS-HD HR (Updated!):
|
Update: TrueHD: Multi-Channel opens including noise As I am not sure at all if my laptop's HDMI connection actually supports DTS-HD-MA / TrueHD - I keep it as is for now :-) Await @MilhouseVH tests |
DTSHD Log, looks quite okay I'd say (though, only noise on my system)
|
TrueHD also looks okay (though noisy):
|
Thanks @Rechi - I only fixed new code. Will sort the rest after we know which version this is stable in upstream PA and fine from semantics. |
@ford-prefect I had a lookg into pulse's alsa sink implementation. It seems there is a lot signalling still missing: AES0, AES1, AES2, AES3, etc. I don't think setting AES0=0x06 is enough See: https://github.com/xbmc/xbmc/blob/master/xbmc/cores/AudioEngine/Sinks/AESinkALSA.cpp#L456 How did you test DTSHD / TrueHD - is there some sample application, e.g. pacat that succesfully works? |
@fritsch how is this progressing? Is it active or would you like to put it on the the backburner? |
I've started working on the PA bits for this again, so please let me know what I can do to help move this forwards. |
Awesome to see. I rebased and squashed the changes. Some of the ifdefs / version handling will need adjustment as they still focus towards version 13. |
The PulseAudio branch should be good for testing against XBMC (I've implemented the AES bits as well).
I think I am also hitting this problem, so not sure how best to test this tbh. |
You could start kodi like this: |
It is available, but does not work. Ditto for trying this with ✅ |
With Pulseaudio 13, support for DTS-HD and TrueHD IEC was added. Sadly there was barely any documentation on how to use it.
Make sure to add the formats to your sink (check its number with pactl list sinks, in my case it's 0):
If you want to test, please start pulseaudio with -vvv as arguments and provide a link to your kodi debuglog. Thanks much.