Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pvr] Update and persist channel group members from client on boot if… #16696

Merged
merged 1 commit into from Oct 2, 2019

Conversation

phunkyfish
Copy link
Contributor

… changed

Description

Persists the channel group members after receiving the data from the PVR addons.

Motivation and Context

When the PVR addon loads if the channel group members change this was not persisted and the only to way to change it was to reset the PVR database (or have the addon trigger a channel/group) reload.

How Has This Been Tested?

On Mac OSX, using both a v35 and v36 PVR DB.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@phunkyfish phunkyfish requested a review from ksooo October 1, 2019 20:14
@ksooo ksooo added Component: PVR Type: Fix non-breaking change which fixes an issue v19 Matrix labels Oct 1, 2019
@ksooo ksooo added this to the Matrix 19.0-alpha 1 milestone Oct 1, 2019
Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some more love.

xbmc/pvr/PVRGUIActions.cpp Outdated Show resolved Hide resolved
xbmc/pvr/PVRGUIActions.cpp Outdated Show resolved Hide resolved
xbmc/pvr/dialogs/GUIDialogPVRChannelManager.cpp Outdated Show resolved Hide resolved
xbmc/pvr/channels/PVRChannelGroup.cpp Show resolved Hide resolved
xbmc/pvr/channels/PVRChannelGroup.cpp Show resolved Hide resolved
xbmc/pvr/channels/PVRChannelGroup.cpp Show resolved Hide resolved
xbmc/pvr/channels/PVRChannelGroup.cpp Outdated Show resolved Hide resolved
xbmc/pvr/channels/PVRChannelGroup.cpp Outdated Show resolved Hide resolved
xbmc/pvr/channels/PVRChannelGroup.cpp Outdated Show resolved Hide resolved
xbmc/pvr/channels/PVRChannelGroup.cpp Outdated Show resolved Hide resolved
@phunkyfish phunkyfish force-pushed the persist-channel-group-members branch from a05edc8 to 554fdb1 Compare October 2, 2019 06:54
Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@phunkyfish phunkyfish merged commit c3b50ae into xbmc:master Oct 2, 2019
@phunkyfish phunkyfish deleted the persist-channel-group-members branch October 2, 2019 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PVR Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants