[PVR] Refactor PVR jobs. Get rid of PVRJobs.(h|cpp). #16698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
added
Type: Cleanup
phunkyfish
requested changes
Oct 2, 2019
Rechi
reviewed
Oct 2, 2019
ksooo
force-pushed
the
pvr-refactor-jobs
branch
from
dac0d9a
to
85b817a
Compare
|
@Rechi @phunkyfish all requested/suggested changes are in. Please comment or approve. |
ksooo
force-pushed
the
pvr-refactor-jobs
branch
from
85b817a
to
a08ef0a
Compare
|
jenkins build this please |
Rechi
reviewed
Oct 2, 2019
| std::string m_icon; | ||
|
|
||
| Event(bool bNotifyUser, bool bError, const std::string& label, const std::string& msg, const std::string& icon) | ||
| : m_bNotifyUser(bNotifyUser), m_bError(bError), m_label(label), m_msg(msg), m_icon(icon) {} |
There was a problem hiding this comment.
Suggested change
| : m_bNotifyUser(bNotifyUser), m_bError(bError), m_label(label), m_msg(msg), m_icon(icon) {} | |
| : m_bNotifyUser(bNotifyUser) | |
| , m_bError(bError) | |
| , m_label(label) | |
| , m_msg(msg) | |
| , m_icon(icon) | |
| { | |
| } |
There was a problem hiding this comment.
Nope. This looks so ugly that I will not accept this coding guideline.
There was a problem hiding this comment.
As I already told you, if you do not like the style submit a PR that changes the docs and clang-format configuration.
| public: | ||
| CPVRChannelTimeoutJobBase() = delete; | ||
| CPVRChannelTimeoutJobBase(PVR::CPVRGUIChannelNavigator& channelNavigator, int iTimeout) | ||
| : m_channelNavigator(channelNavigator) |
There was a problem hiding this comment.
Suggested change
| : m_channelNavigator(channelNavigator) | |
| : m_channelNavigator(channelNavigator) |
| { | ||
| public: | ||
| CPVRChannelEntryTimeoutJob(PVR::CPVRGUIChannelNavigator& channelNavigator, int iTimeout) | ||
| : CPVRChannelTimeoutJobBase(channelNavigator, iTimeout) {} |
There was a problem hiding this comment.
Suggested change
| : CPVRChannelTimeoutJobBase(channelNavigator, iTimeout) {} | |
| : CPVRChannelTimeoutJobBase(channelNavigator, iTimeout) | |
| { | |
| } |
| { | ||
| public: | ||
| CPVRChannelInfoTimeoutJob(PVR::CPVRGUIChannelNavigator& channelNavigator, int iTimeout) | ||
| : CPVRChannelTimeoutJobBase(channelNavigator, iTimeout) {} |
There was a problem hiding this comment.
Suggested change
| : CPVRChannelTimeoutJobBase(channelNavigator, iTimeout) {} | |
| : CPVRChannelTimeoutJobBase(channelNavigator, iTimeout) | |
| { | |
| } |
| { | ||
| public: | ||
| CPVRLambdaJob() = delete; | ||
| CPVRLambdaJob(const std::string& type, F&& f) : m_type(type), m_f(std::forward<F>(f)) {} |
There was a problem hiding this comment.
Suggested change
| CPVRLambdaJob(const std::string& type, F&& f) : m_type(type), m_f(std::forward<F>(f)) {} | |
| CPVRLambdaJob(const std::string& type, F&& f) | |
| : m_type(type) | |
| , m_f(std::forward<F>(f)) | |
| { | |
| } |
| class CPVRManagerJobQueue | ||
| { | ||
| public: | ||
| CPVRManagerJobQueue() : m_triggerEvent(false) {} |
There was a problem hiding this comment.
Suggested change
| CPVRManagerJobQueue() : m_triggerEvent(false) {} | |
| CPVRManagerJobQueue() | |
| : m_triggerEvent(false) | |
| { | |
| } |
phunkyfish
approved these changes
Oct 2, 2019
|
Looks good 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of PVR jobs. Basic ideas: Use lambda jobs to reduce boilerplate code and better encapsulation by reducing visibility of the job implementations.
Runtime-tested on macOS and Android, latest Kodi master.