New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PVR] PVRManager: Factor out playback state functionality into its own class #16699
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you prefer the style you used in this PR, crate a PR with documentation and clang-format configuration changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outside of the left align from Rechi it looks good. Not sure if my comments originate from NULL or nullptr so maybe the comment not so important. Up to you.
For the records: I do not accept any clang-format stuff as a blocker for any PR. Team Kodi developers have no common agreement or at least consensus on the rule set you're trying to enforce here by blocking a PR. I will incorporate all requested changes except the ctor initlist reformat stuff and merge as soon as Jenkins is happy. |
That's the reason I'm asking you to submit a PR with your suggestions. Otherwise everyone wants to keep his preferred code style. |
Sigh. Not worth the fight. I have better things to do. I will just obey the existing rules. |
992bf7b
to
321f2e3
Compare
Here we go. All (!) requested changes are in. Please approve or comment on other findings. |
code follows now current coding guidelines and clang-format configuration
Another PVR refactoring PR. Idea is decoupling and separation of concerns.
In the distant future PVR shall no more know anything about any application playback states. So, this PR is a step into this direction.
Runtime-tested on macOS and Android, latest Kodi master.