Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pvr] refactoring - remove extra whitespace #16703

Merged
merged 1 commit into from Oct 3, 2019
Merged

[pvr] refactoring - remove extra whitespace #16703

merged 1 commit into from Oct 3, 2019

Conversation

phunkyfish
Copy link
Contributor

@phunkyfish phunkyfish commented Oct 2, 2019 •
edited

Description

Cleanup extra whitespace in PVR component.

Did not remove whitespace for SQL statements (PVR and EPG) or GUIViewStatePVR

Motivation and Context

How Has This Been Tested?

On OSX

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@phunkyfish phunkyfish added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Component: PVR v19 Matrix labels Oct 2, 2019
@phunkyfish phunkyfish requested a review from ksooo October 2, 2019 21:30
Rechi
Rechi reviewed Oct 3, 2019
View reviewed changes
xbmc/pvr/addons/PVRClient.h Outdated Show resolved Hide resolved
xbmc/pvr/addons/PVRClient.h Outdated Show resolved Hide resolved
xbmc/pvr/dialogs/GUIDialogPVRTimerSettings.h Outdated Show resolved Hide resolved
xbmc/pvr/recordings/PVRRecording.cpp Outdated Show resolved Hide resolved
xbmc/pvr/recordings/PVRRecording.cpp Outdated Show resolved Hide resolved
xbmc/pvr/settings/PVRSettings.cpp Outdated Show resolved Hide resolved
xbmc/pvr/timers/PVRTimerType.cpp Outdated Show resolved Hide resolved
xbmc/pvr/timers/PVRTimerType.cpp Outdated Show resolved Hide resolved
xbmc/pvr/timers/PVRTimersPath.cpp Outdated Show resolved Hide resolved
ksooo
ksooo approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@phunkyfish your button

@phunkyfish phunkyfish added this to the Matrix 19.0-alpha 1 milestone Oct 3, 2019
@phunkyfish phunkyfish merged commit 5580cdd into xbmc:master Oct 3, 2019
@phunkyfish phunkyfish deleted the pvr-remove-whitespace branch October 3, 2019 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rechi Rechi Rechi left review comments

@Acidzero2020 Acidzero2020 Acidzero2020 left review comments

@ksooo ksooo ksooo approved these changes

Assignees
No one assigned
Labels
Component: PVR Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v19 Matrix
Projects
None yet
Milestone
Matrix 19.0-alpha 1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@phunkyfish @ksooo @Rechi @Acidzero2020