Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios] Info.plist cleanup #16721

Merged

Conversation

kambala-decapitator
Copy link
Contributor

Description

Sorts keys alphabetically, removes hardcoded keys, sets real app version.

Motivation and Context

Now installed version can be seen immediately in Xcode's Devices window without the need to open app, also fixes Xcode warning "existing info.plist key will be overwritten".

How Has This Been Tested?

Compiled and ran on a device.

Screenshots (if appropriate):

Screenshot 2019-10-05 at 16 25 26

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@kambala-decapitator kambala-decapitator added Platform: iOS Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Type: Improvement non-breaking change which improves existing functionality v19 Matrix labels Oct 5, 2019
@jenkins4kodi jenkins4kodi added the Rebase needed PR that does not apply/merge cleanly to current base branch label Oct 5, 2019
@jenkins4kodi jenkins4kodi removed the Rebase needed PR that does not apply/merge cleanly to current base branch label Oct 6, 2019
@kambala-decapitator kambala-decapitator merged commit 39bf168 into xbmc:master Oct 7, 2019
@kambala-decapitator kambala-decapitator deleted the ios-infoplist-cleanup branch October 7, 2019 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: iOS Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Type: Improvement non-breaking change which improves existing functionality v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants