Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdvancedSettings: Fix arttype return #16736

Merged
merged 1 commit into from Oct 8, 2019

Conversation

DaVukovic
Copy link
Member

Description

Missing semi-colon after return.

reported here: #16734
As this is broken in Kodi 18.4 as well, I would say this is also a candidate for a backport.

Motivation and Context

Fixes: #16734

How Has This Been Tested?

Not tested, but I guess the change is obvious.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

Copy link
Member

@DaveTBlake DaveTBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @DaVukovic

@DaveTBlake DaveTBlake merged commit 548692d into xbmc:master Oct 8, 2019
@DaVukovic DaVukovic deleted the advancedsettings branch October 9, 2019 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missed semicolon changes flow of execution (minor bug)
2 participants