Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android][Python] remove wrong platform suffix from PyCryptodome native libraries #16790

Merged
merged 1 commit into from Oct 20, 2019

Conversation

peak3d
Copy link
Contributor

@peak3d peak3d commented Oct 16, 2019

Description

Python build system builds native PyCryptoDome libraries with a filename including platform and os identifiers from the build host (e.g. _MD2.cpython-37-x86_64-linux-gnu.so for android arm build)

This PR cuts the host and platform identifier out of the file name during android packaging process.

Motivation and Context

native libraries can not be found during runtime

How Has This Been Tested?

Startup sequence of netflix addon on android armv7 system

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

@peak3d peak3d added this to the Matrix 19.0-alpha 1 milestone Oct 16, 2019
@peak3d peak3d merged commit 8679e4d into xbmc:master Oct 20, 2019
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Jan 21, 2020
[Android][Python] remove wrong platform suffix from PyCryptodome native libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant