Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CODEOWNERS file to help selecting reviewers #16818

Merged
merged 5 commits into from
Nov 17, 2019
Merged

Conversation

lrusak
Copy link
Contributor

@lrusak lrusak commented Oct 22, 2019

As discussed at devcon this adds the CODEOWNERS file. I encourage all core devs to add their relevant sections. There will be a lot of code that is missing maintainers.

this fixes https://github.com/xbmc/board/issues/114

@lrusak lrusak added Documentation No Jenkins do not run automatic Jenkins builds on this PR v19 Matrix labels Oct 22, 2019
@lrusak lrusak added this to the Leia 18.5 milestone Oct 22, 2019
@lrusak lrusak requested a review from yol October 22, 2019 16:47
Copy link
Member

@yol yol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add myself to Wayland afterwards

@ksooo
Copy link
Member

ksooo commented Oct 28, 2019

@lrusak could you please add:

/xbmc/cores/VideoPlayer/DVDInputStreams/InputStreamPVR*.* @ksooo
/xbmc/interfaces/builtins/PVR*.* @ksooo
/xbmc/interfaces/json-rpc/PVR*.* @ksooo
/xbmc/guilib/GUIRangesControl.* @ksooo
/xbmc/guilib/guiinfo/GUIInfoProvider.h @ksooo
/xbmc/guilib/guiinfo/GUIInfoProviders.* @ksooo
/xbmc/guilib/guiinfo/IGUIInfoProvider.h @ksooo
/xbmc/pvr/** @ksooo
/xbmc/settings/SettingsComponent.* @ksooo 

@DaveTBlake
Copy link
Member

DaveTBlake commented Oct 28, 2019

What is the best way to handle the initial creation of this file - each do our own PR of this file to add ownership, or post here and @lrusak will do it?

Assuming the latter (or we could end up tripping over one another), for me please add

/xbmc/filesystem/Music*.* @DaveTBlake
/xbmc/interfaces/json-rpc/AudioLibrary.*  @DaveTBlake
/xbmc/music/** @DaveTBlake 

@garbear
Copy link
Member

garbear commented Oct 28, 2019

I'll cover

/xbmc/cores/RetroPlayer/** @garbear
/xbmc/games/** @garbear
/xbmc/input/** @garbear
/xbmc/peripherals/** @garbear

@lrusak
Copy link
Contributor Author

lrusak commented Oct 28, 2019

I don't really want to add everyone myself 😝 I've added some commits for the requested people but I'd rather merge this and have others create their own PR's 😸

@garbear
Copy link
Member

garbear commented Oct 28, 2019

/.github/CODEOWNERS @lrusak

@lrusak lrusak modified the milestones: Leia 18.5, Matrix 19.0-alpha 1 Nov 4, 2019
@yol
Copy link
Member

yol commented Nov 17, 2019

GitHub docs say we don't need /**, so I'm going to remove that part to make it a bit easier on the eyes

@yol yol merged commit 049d604 into xbmc:master Nov 17, 2019
@yol
Copy link
Member

yol commented Nov 17, 2019

Let's see what happens... ;-)

Maven85 pushed a commit to Maven85/kodi that referenced this pull request Jan 21, 2020
add CODEOWNERS file to help selecting reviewers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation No Jenkins do not run automatic Jenkins builds on this PR v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants