fixed: support shoutcast over https #16874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notspiff
referenced
this pull request
Nov 6, 2019
…th a shout:// url git-svn-id: https://xbmc.svn.sourceforge.net/svnroot/xbmc/trunk@35483 568bbfeb-2a22-0410-94d2-cc84cf5bfa90
notspiff
added
the
Type: Improvement
notspiff
force-pushed
the
fix_shoutcast_https
branch
from
499dce0
to
6a686e1
Compare
|
jenkins build this please |
1 similar comment
|
jenkins build this please |
we can no longer blindly replace protocol with http since shoutcast over https is now a thing. replace shout:// protocol with http replace shouts://protocol with https
notspiff
force-pushed
the
fix_shoutcast_https
branch
from
6a686e1
to
1e87d89
Compare
|
@Rechi this is as good as it gets, no ? |
|
yes |
DaveTBlake
added
Type: Fix
|
@notspiff called "fix" in title so changed the label to match. Does v18 have this issue? If so then backport please |
|
it does have the issue, everything since 2010 has it ;) if you consider it backport material, i'm on it. |
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Jan 21, 2020
fixed: support shoutcast over https
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we can no longer blindly replace protocol with http since
shoutcast over https is now a thing.
replace shout:// protocol with http
replace shouts://protocol with https
Description
Shoutcast over https was not working since protocol was blindly replaced with http.
Motivation and Context
Make fernetmenta happy.
How Has This Been Tested?
Tried a https shoutcast stream.