Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RendererMediaCodecSurface: Announce vertical shift as well #16907

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

fritsch
Copy link
Member

@fritsch fritsch commented Nov 13, 2019

This was disabled - I did not find any documentation why.

@fritsch fritsch requested a review from peak3d November 13, 2019 19:46
@fritsch
Copy link
Member Author

fritsch commented Nov 13, 2019

@peak3d forum whines about this feature missing. Do you know why it was disabled? From git history it seems, that it just was forgotten to enable after refactoring.

@peak3d
Copy link
Contributor

peak3d commented Nov 13, 2019

I'm fine if this PR has any effect, I cannot recall where its finally used. I haver never visited any implementation for this in the android code t.b.h.

@fritsch
Copy link
Member Author

fritsch commented Nov 13, 2019

Then it was removed by accident: 16c4af9#diff-f88a684f68595110fb8d6e4d15b74983R132

Old code just returned "true" for everything.

@fritsch
Copy link
Member Author

fritsch commented Nov 14, 2019

jenkins is happy (minus UWP), clang-format as well.

@fritsch fritsch merged commit 244618b into xbmc:master Nov 14, 2019
@fritsch fritsch added this to Closed in Android specific (issues) via automation Nov 14, 2019
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Jan 21, 2020
RendererMediaCodecSurface: Announce vertical shift as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport: Done Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants